Added Employee detail component, Request component integration with employee and request services, styling, and refactoring #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Employee and request service
SKrudra
requested changes
Oct 8, 2018
| public void updateRequestStatus(@PathVariable Long empId, RequestStatus requestStatus){ | ||
| requestService.setRequestStatus(requestStatus, empId); | ||
| //2. Update Request Status PUT/request/{reqId} | ||
| // @RequestMapping(value="/api/request", method=RequestMethod.PUT) |
There was a problem hiding this comment.
Removed commented out code unless you need it.
| requestService.addRequest(newRequest); | ||
| @RequestMapping(value="/api/request", method=RequestMethod.POST) | ||
| public ResponseEntity createRequest(@RequestBody Request newRequest){ | ||
| System.out.println(newRequest); |
There was a problem hiding this comment.
Don't comment any system logs. Use logger if you want to add logs to the app. [log4j]
| emp = employeeService.getEmployee(newRequest.getEmployee().getId()); | ||
| Request req =newRequest; | ||
| req.setEmployee(emp); | ||
| this.requestService.addRequest(req); |
There was a problem hiding this comment.
Do you really need to use "this" keyword?
| request.requestDescription = requestDescription; | ||
| request.requestStatus='OPEN'; | ||
| request.comment="NA"; | ||
| console.log(request); |
|
Required changes done. |
SKrudra
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.