cleanup: delete :llm-runtime:kqwen module#126
Merged
Conversation
Phase 5b cleanup. The `:llm-runtime:kqwen` module wrapped the legacy LlamaIngestion-based Qwen loader path (`QwenIngestion`); it had no remaining consumers after #121 swapped the kllama CLI's Qwen branch to the DSL path (`QwenNetworkLoader` + `OptimizedLLMRuntime`). Verified zero external references via grep: `project(":llm-runtime:kqwen")` → no hits `import sk.ainet.apps.kqwen` → no hits The only mention was `settings.gradle.kts` itself, removed in this PR. `./gradlew projects` now shows the module is gone from the graph; :llm-runtime:kllama, :llm-apps:skainet-cli, :llm-apps:kllama-cli, :llm-inference:qwen tests/builds all pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
:llm-runtime:kqwenmodule wrapped the legacyLlamaIngestion-based Qwen loader path (QwenIngestion). It had no remaining consumers after #121 swapped the kllama CLI's Qwen branch to the DSL path (QwenNetworkLoader+OptimizedLLMRuntime).Verification — zero external references
Only the
settings.gradle.ktsinclude itself. Removed in this PR (replaced with a comment explaining why for future readers)../gradlew projectsnow shows the module is gone from the graph.Diff stats
build.gradle.kts+QwenIngestion.kt, 88 lines).settings.gradle.kts, +4 / -1 — comment + removedinclude).Test plan
:llm-runtime:kllama:jvmTest,:llm-apps:skainet-cli:build,:llm-apps:kllama-cli:build,:llm-inference:qwen:jvmTestall pass.🤖 Generated with Claude Code