update #5
Merged
update #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…psorcery-org#1320) * To parse enums, use TryParse() instead of Parse() in a try block. * Fix indentation.
…org#1325) * Use a more idiomatic approach to convert a DateTime to Unix time. * Rename the function GetEpoch() to ToUnixTime(), as is this function doesn't return the epoch, but the number of seconds since the epoch. Also add a unit test to make sure this implementation is not subject to the year 2038 problem.
…tion() (sipsorcery-org#1324) when parameter "find" is an empty string. If we don't check for the length of parameter "find", then the first indexing of "findArray" raises an IndexOutOfRangeException.
* fix stream retrieval bug RTC updates * add translations for tray app and installer * fix for ptz serialization use wyze camera name from url * fix bug in g722 codec * Only get stream format once Add timeout to ice gathering Add prefer H264 flag for compatible formats * revert * Optimise SendVideo and SendAudio (only get SendingFormat once) Add sanity check for ICE Gathering timeout * Optimise SendVideo and SendAudio (only get SendingFormat once) Add sanity check for ICE Gathering timeout Fix bug in g722 codec * remove turn folder * Remove turn folder * Move gather timeout to config * Fix rounding bug in SendAudioFrame Fix bug where duplicate durations were being added to local track timestamp in SendAudioFrame Ignore H264 formats that use unsupported packetization modes Clean up logic in AreMatch * Remove comment marker * remove comment marker * Check for null * Fix bug with HasVideo and HasAudio * Fix audio parsing with multiple ports * Add unit test
… bug fixes (sipsorcery-org#1331) * fix stream retrieval bug RTC updates * add translations for tray app and installer * fix for ptz serialization use wyze camera name from url * fix bug in g722 codec * Only get stream format once Add timeout to ice gathering Add prefer H264 flag for compatible formats * revert * Optimise SendVideo and SendAudio (only get SendingFormat once) Add sanity check for ICE Gathering timeout * Optimise SendVideo and SendAudio (only get SendingFormat once) Add sanity check for ICE Gathering timeout Fix bug in g722 codec * remove turn folder * Remove turn folder * Move gather timeout to config * Fix rounding bug in SendAudioFrame Fix bug where duplicate durations were being added to local track timestamp in SendAudioFrame Ignore H264 formats that use unsupported packetization modes Clean up logic in AreMatch * remove comment marker * Check for null * Fix bug with HasVideo and HasAudio * Fix locking issue * fix lock * Fix stuttering on connect * Fix DtlsSrtpTransport bug * Fix issues with buffer over-runs * Add TWCC header extension support * Add support for TWCC Fix SDP parsing of audio m fields with ports Return null if stream not matched (was causing issues with RTP processing) Use PrimaryStream to unprotect incoming RTP packets Fix logic bug in SendRtpRaw Prevent some buffer over-reads var videoExtensions = new Dictionary<int, RTPHeaderExtension>(); videoExtensions.Add(extensionId, RTPHeaderExtension.GetRTPHeaderExtension(extensionId++, TransportWideCCExtension.RTP_HEADER_EXTENSION_URI, SDPMediaTypesEnum.video)); MediaStreamTrack videoTrack = new MediaStreamTrack(SDPMediaTypesEnum.video, false, formats.Select(x => new SDPAudioVideoMediaFormat(x)).ToList(), MediaStreamStatusEnum.SendOnly, null, videoExtensions ); in OnReceiveReport access rr.TWCCFeedback * Use feedback type parser * Add notes * Fix limit check * Fix issues with parsing TWCC packet parsing * ignore invalid chunkType * remove console.writeline * Update src/net/RTCP/RTCPCompoundPacket.cs Co-authored-by: Paulo Morgado <470455+paulomorgado@users.noreply.github.com> * Update src/net/RTCP/RTCPCompoundPacket.cs Co-authored-by: Paulo Morgado <470455+paulomorgado@users.noreply.github.com> * Update for code review * remove announcement portcount (move to new PR) * Add SRTP fallback * bug fix --------- Co-authored-by: Paulo Morgado <470455+paulomorgado@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.