Avoid skipping tests when build Python wheels #602
Comments
jesper-friis
added a commit
that referenced
this issue
Aug 24, 2023
# Description Closes #517 Added new requirements file `requirements_full.txt` with all optional requirements. Getting rust, cargo and poetry properly installed in the docker images for building the wheels is followed up in issue #601. Follow up with issue #602 - Avoid skipping tests when build Python wheels. **Remaining things to be done:** - [x] Fix failing tests - [x] Make it possible to install dlite with `pip install DLite-Python[full]` to include all optional dependencies. - [x] Document how to install DLite with all dependencies included. - [x] Ensure that tests run if yaml is missing (avoid false CI failures on this PR before we get everything correctly installed in the docker containers used for building the wheels. This should not be used to skip yaml-dependent tests when testing the wheels). - [ ] Agree on whether to accept this PR or the solution suggested in issue #603. ## Type of change - [x] Bug fix & code cleanup - [ ] New feature - [ ] Documentation update - [ ] Test update ## Checklist for the reviewer This checklist should be used as a help for the reviewer. - [ ] Is the change limited to one issue? - [ ] Does this PR close the issue? - [ ] Is the code easy to read and understand? - [ ] Do all new feature have an accompanying new test? - [ ] Has the documentation been updated as necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, when building Python wheels, some tests are skipped. See e.g. https://github.com/SINTEF/dlite/actions/runs/5901236903/job/16007030512?pr=594#step:6:882
Figure out why this is happening and ensure that the tests run.
I am little surprised that the tests are not running, since we install all dependencies should be installed in the templates for the docker images in .github/docker/Dockerfile-*.template. Maybe an old version of the docker image is picked up?
The text was updated successfully, but these errors were encountered: