Fix valgrind error: Conditional jump or move depends on uninitialised…

… value(s) (#7518) Signed-off-by: Misiu Godfrey <misiu.godfrey@kraken.mapd.com>
SINHASantos · Sep 28, 2023 · 492c0fe · 492c0fe
1 parent 9fb881a
commit 492c0fe
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/QueryEngine/Execute.h b/QueryEngine/Execute.h
@@ -1540,7 +1540,7 @@ class Executor {
   static uint32_t gpu_active_modules_device_mask_;
   static void* gpu_active_modules_[max_gpu_count];
   // indicates whether this executor has been interrupted
-  std::atomic<bool> interrupted_;
+  std::atomic<bool> interrupted_{false};
 
   mutable std::mutex str_dict_mutex_;
 

diff --git a/Tests/ExecuteTest.cpp b/Tests/ExecuteTest.cpp
@@ -26012,6 +26012,18 @@ TEST_F(Select, InfNanTest) {
   }
 }
 
+// Use a non-empty session_id to test call to Executor::removeFromQuerySessionList().
+// This test verifies QE-952 fixes a valgrind error.
+TEST_F(Select, RemoveFromQuerySessionList) {
+  SKIP_ALL_ON_AGGREGATOR();
+  for (auto dt : {ExecutorDeviceType::CPU, ExecutorDeviceType::GPU}) {
+    SKIP_NO_GPU();
+    char const* query = "SELECT COUNT(*) FROM test;";
+    char const* session_id = "0123456789ABCDEF0123456789ABCDEF";  // len=32
+    QR::get()->runSQLWithAllowingInterrupt(query, session_id, dt);
+  }
+}
+
 class DateAndTimeFunctionsTest : public QRExecutorDeviceParamTest {};
 
 TEST_P(DateAndTimeFunctionsTest, CastLiteralToDate) {