Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest parallaxes from Ultracool sheet #528

Merged
merged 11 commits into from
Jul 8, 2024

Conversation

Exu-112
Copy link
Collaborator

@Exu-112 Exu-112 commented Jul 1, 2024

Short description: Ingest of parallaxes from Ultracool sheet, as well as rework of ingest_parallax function

Link to relevant issue: Closes #527

For data ingests:

  • includes script used for ingest
  • includes modified JSON files
  • Add new tests
  • Update the Versions table

@Exu-112 Exu-112 changed the title code Ingest parallaxes from Ultracool sheet Jul 1, 2024
simple/utils/astrometry.py Outdated Show resolved Hide resolved
simple/utils/astrometry.py Outdated Show resolved Hide resolved
simple/utils/astrometry.py Outdated Show resolved Hide resolved
tests/test_astrometry.py Outdated Show resolved Hide resolved
@kelle
Copy link
Collaborator

kelle commented Jul 2, 2024

return a dictionary called flags.

  • "added": True if it's added and False if it's skipped.
  • "content": the data that was attempted to add
  • "message": string which includes information about why skipped

@Exu-112
Copy link
Collaborator Author

Exu-112 commented Jul 3, 2024

return a dictionary called flags.

  • "added": True if it's added and False if it's skipped.
  • "content": the data that was attempted to add
  • "message": string which includes information about why skipped

How should errors be handled? Should we return with the flags immediately or raise an error with the flags contained within? The first option would be a little confusing with regard to the raise_error flag and the fact that we don't raise errors anymore, but the second doesn't give you the flags dictionary anyways which seems to defeat the point of having it in the first place.

@kelle
Copy link
Collaborator

kelle commented Jul 3, 2024

When raise_error is True, you don't need to return anything. But when raise_error is False is when the flags are most important cause it should return added: False.

simple/utils/astrometry.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great but still some tweaking to do.

scripts/ingests/ultracool_sheet/Ingest_Parallax.py Outdated Show resolved Hide resolved
scripts/ingests/ultracool_sheet/Ingest_Parallax.py Outdated Show resolved Hide resolved
scripts/ingests/ultracool_sheet/Ingest_Parallax.py Outdated Show resolved Hide resolved
scripts/ingests/ultracool_sheet/Ingest_Parallax.py Outdated Show resolved Hide resolved
simple/utils/astrometry.py Outdated Show resolved Hide resolved
simple/utils/astrometry.py Outdated Show resolved Hide resolved
simple/utils/astrometry.py Outdated Show resolved Hide resolved
simple/utils/astrometry.py Show resolved Hide resolved
scripts/ingests/ultracool_sheet/Ingest_Parallax.py Outdated Show resolved Hide resolved
tests/test_astrometry.py Outdated Show resolved Hide resolved
simple/utils/astrometry.py Outdated Show resolved Hide resolved
tests/test_astrometry.py Outdated Show resolved Hide resolved
tests/test_astrometry.py Outdated Show resolved Hide resolved
simple/utils/astrometry.py Outdated Show resolved Hide resolved
simple/utils/astrometry.py Outdated Show resolved Hide resolved
@kelle kelle merged commit d0e29ba into SIMPLE-AstroDB:main Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingest literature parallaxes from Ultracool Sheet
2 participants