-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingest parallaxes from Ultracool sheet #528
Conversation
return a dictionary called
|
How should errors be handled? Should we return with the flags immediately or raise an error with the flags contained within? The first option would be a little confusing with regard to the raise_error flag and the fact that we don't raise errors anymore, but the second doesn't give you the flags dictionary anyways which seems to defeat the point of having it in the first place. |
When raise_error is True, you don't need to return anything. But when raise_error is False is when the flags are most important cause it should return added: False. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great but still some tweaking to do.
Short description: Ingest of parallaxes from Ultracool sheet, as well as rework of ingest_parallax function
Link to relevant issue: Closes #527
For data ingests: