Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename spectrum to access_url #494

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

dr-rodriguez
Copy link
Collaborator

@dr-rodriguez dr-rodriguez commented Apr 19, 2024

Short description:
Rename the spectrum column to access_url in the Spectra table

Link to relevant issue: Closes #477

For data ingests:
[X] includes script used for ingest
[X] includes modified JSON files
[X] Add/update tests
[X] Update the Versions table

@dr-rodriguez dr-rodriguez changed the title Rename spectrum to access_url; closes #477 Rename spectrum to access_url Apr 19, 2024
@dr-rodriguez dr-rodriguez requested a review from kelle April 19, 2024 18:13
@dr-rodriguez
Copy link
Collaborator Author

Do we want/need an entry in Versions as described in the template?

@dr-rodriguez
Copy link
Collaborator Author

Also, I did notice the re-ordering of a handful of SpectralTypes entries. Not sure how to resolve that yet, but maybe this PR will sync them to their proper order?

Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update tests/scheduled_checks.py

@kelle
Copy link
Collaborator

kelle commented Apr 19, 2024

Also, I did notice the re-ordering of a handful of SpectralTypes entries. Not sure how to resolve that yet, but maybe this PR will sync them to their proper order?

I'm happy to do that here since so many files are being touched anyway. If it happens again, however, we should open an issue and see if we can prescribe the order.

@kelle
Copy link
Collaborator

kelle commented Apr 19, 2024

Do we want/need an entry in Versions as described in the template?

I vote yes, I think this change warrants a release and a version increment. We'll need to be careful implementing on the website because this change may break the web app.

@dr-rodriguez
Copy link
Collaborator Author

Updated scheduled_checks and added an entry to Versions (2024.4).
These are now the versions we have:

version start_date  end_date                    description                  
------- ---------- ---------- -----------------------------------------------
 2022.1 2020-06-22 2022-08-23                                 Initial release
 2022.2 2022-08-23 2022-10-11                                            None
 2022.3 2022-10-11 2022-10-13                            Added VHS 1256b data
 2022.4 2022-10-14 2022-10-16                                                
 2022.5 2022-10-16 2022-12-28 Adds T and Y dwarfs from Leggett 21 compilation
 2023.1 2022-12-28 2023-07-11                                   Schema rework
 2023.2 2023-07-11 2023-07-25                Added JWST spectra for VHS 1256b
 2023.3 2023-07-25 2023-10-18             Companions table, fixed IRS spectra
 2023.4 2023-10-18 2023-12-12                               Added two sources
 2023.5 2023-12-12 2023-12-29     Included Roth sources, fixed Bard14 spectra
 2024.1 2023-12-29 2024-02-15          Added JWST spectrum for WISE 1935-1546
 2024.2 2024-02-15 2024-03-05                                  Regime cleanup
 2024.3 2024-03-05 2024-04-17                 UCDs in PhotometryFilters table
 2024.4 2024-04-17 2024-04-19 Renaming Spectra.spectrum to Spectra.access_url
 latest 2024-04-19       None                          Version in development

@dr-rodriguez dr-rodriguez requested a review from kelle April 19, 2024 19:58
Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dr-rodriguez
Copy link
Collaborator Author

I'll hold off on merging until next week, just in case we want to do the explicit release then (which as you say would break the website). Better to do it when we have time to address it quickly then.

@dr-rodriguez dr-rodriguez merged commit 7560428 into SIMPLE-AstroDB:main Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change spectrum to access_url in the Spectrum table.
2 participants