-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename spectrum to access_url #494
Conversation
Do we want/need an entry in Versions as described in the template? |
Also, I did notice the re-ordering of a handful of SpectralTypes entries. Not sure how to resolve that yet, but maybe this PR will sync them to their proper order? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update tests/scheduled_checks.py
I'm happy to do that here since so many files are being touched anyway. If it happens again, however, we should open an issue and see if we can prescribe the order. |
I vote yes, I think this change warrants a release and a version increment. We'll need to be careful implementing on the website because this change may break the web app. |
Updated scheduled_checks and added an entry to Versions (2024.4).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I'll hold off on merging until next week, just in case we want to do the explicit release then (which as you say would break the website). Better to do it when we have time to address it quickly then. |
Short description:
Rename the
spectrum
column toaccess_url
in the Spectra tableLink to relevant issue: Closes #477
For data ingests:
[X] includes script used for ingest
[X] includes modified JSON files
[X] Add/update tests
[X] Update the Versions table