Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script reorg #466

Merged
merged 10 commits into from
Feb 21, 2024
Merged

Script reorg #466

merged 10 commits into from
Feb 21, 2024

Conversation

kelle
Copy link
Collaborator

@kelle kelle commented Feb 19, 2024

Moving ingest scripts around to be less cluttered.

Link to relevant issue: Closes #463

Done:

  • I’ve made a simple/ directory where the different types of python code exists.
  • I’ve broken out the various utils functions into their own modules in a simple.utils/ folder.
  • I added an old/ folder to the simple.scripts.ingests/ folder to hide the older/outdated ingest scripts.

To discuss:

  • I’d be interested in better names for the scripts/ folder. This is code which has been used in the past to modify the database holdings. Including ingests, updates, and spectra_conversions.
  • Also a better name for utils which contains the helper functions used by the scripts. (many, but not all of these will be moved to astrodb_scripts)

@kelle
Copy link
Collaborator Author

kelle commented Feb 19, 2024

this should only have one commit. I clearly have a git problem. :(

@kelle
Copy link
Collaborator Author

kelle commented Feb 20, 2024

I REBASED!!!!

@kelle
Copy link
Collaborator Author

kelle commented Feb 20, 2024

I think the easiest way to review this PR is to browse the branch in my fork: https://github.com/kelle/SIMPLE-db/tree/script-reorg

@kelle kelle marked this pull request as ready for review February 20, 2024 17:27
@kelle kelle merged commit f3bb72b into SIMPLE-AstroDB:main Feb 21, 2024
1 check passed
@kelle kelle deleted the script-reorg branch February 21, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up scripts directory
2 participants