Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test with Simbad check #41

Merged
merged 5 commits into from
Aug 7, 2020

Conversation

dr-rodriguez
Copy link
Collaborator

This adds a test to address issue #20. It will query Simbad for all sources by their Source.source name and then loop over the results to verify that they are not present in the database for more than one source. It handles the Simbad query properly to avoid hundreds of individual calls to their service.

Matching is done by exact name, so binaries will generally not match against each other (ie, TWA 27 does not match TWA 27B).

Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, let's say that there's an object called CoolStar-1 and it's located at 0102-0340. Let's assume it's source name is some variation of it's coordinates, say 2MASS J010234-03401234. So this query will find all the Other names listed for this in SIMBAD and make sure those other names are not also Source Names? E.g., if CoolStar-1 was listed as an other name AND there was another entry in the database with CoolStar-1 as the primary source name, this test would find it? Do I have that right?

tests/test_integrity.py Outdated Show resolved Hide resolved
@dr-rodriguez
Copy link
Collaborator Author

Correct.
The example I was hoping to catch was TWA 27, which was listed as two independent sources:
TWA 27 and 2MASS J12073346-3932539
Instead, they should have been two names for the same single source.

@kelle
Copy link
Collaborator

kelle commented Aug 7, 2020

Great! Happy to merge once conflict is resolved.

@kelle kelle merged commit e923264 into SIMPLE-AstroDB:main Aug 7, 2020
@dr-rodriguez dr-rodriguez deleted the simbad_check branch August 11, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants