-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework photometry filters #379
Rework photometry filters #379
Conversation
This looks good but I admit to not having my head fully wrapped around it. Should we write some tests to go along with it? |
We have tests that query Photometry and PhotometryFilters already, I'm not sure what else we would add to them. The database will not build if the foreign keys and similar are not set. I did notice the tests failing with the Instruments change (#380), but that's a separate PR. |
This change will break the |
This updates the Photometry and PhotometryFilters table in various ways:
Closes #293