IPAC spectra convert #328
Merged
IPAC spectra convert #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
converted data are in issue #308 |
|
Script looks good but some of the filenames are still a little wonky. Eg, BRI and the question mark in 2M1207334. As we discussed, use the source from the database for the object name and use that (with the spaces removed) for the filename. |
kelle
requested changes
Dec 9, 2022
kelle
approved these changes
Dec 18, 2022
| 'telescope': original_header_dict['TELESCOP']['value'], | ||
| 'instrument': insturment, | ||
| 'generated_filename':row['source'].replace(' ',''), | ||
| 'generated_filename':f"{row['source'].replace(' ','')}_{row['reference'].replace(' ','')} " #row['source'].replace(' ',''), #Add reference as a suffix from table |
There was a problem hiding this comment.
Suggested change
| 'generated_filename':f"{row['source'].replace(' ','')}_{row['reference'].replace(' ','')} " #row['source'].replace(' ',''), #Add reference as a suffix from table | |
| 'generated_filename':f"{strip(row['source'])}_{strip(row['reference'])} " # Add reference as a suffix from table |
|
Please upload the converted files to Issue #308 and I'll upload them to AWS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.