[WIP] Minimap

[jfeo]

Here's my progress on a minimap.

There's probably a lot of style issues, etc. and I need to rebase some commits...

Right now, I think it's an issue that the Minimap registers itself with the engine for drawing, but then is deleted when the game is ended (dangling pointer?)

A good way to draw resources is also needed. Where are the colors/palette indices for them?

Video for those who just want to see what it looks like.
implements and fixes #111

[Jon0]

The game_main class should only include pure game state data, so its not the best owner for the minimap, I would suggest looking at main.cpp, line 42-44 the where the are other components, and similarly minimap can be made on the stack (no 'new' constructor),

You would need to change the constructor parameters to minimap(Engine *engine, ... size, ... hudpos) The minimap wont need to have pointers to the unit container and terrain since these can be retrieved in the minimap::on_drawhud() call using GameMain *game = engine.get_game() note: that will return nullptr when there is no active game, in which case no minimap should be drawn.

if the result is not null you will just use game->terrain, and game->placed_units, as before.

[franciscod]

oh the video looks awesome! nice work :D

I almost forgot about gaben, and chuckled when he popped in the background 😄

[TheJJ]

If you perform your rebase, you might want to use git rebase -m -i upstream/master.

[jfeo]

Is there any reason for me to keep the commit history of my own commits, or would it be okay to just squash it all into 1 commit? I think it would be easier for me

[TheJJ]

Sure, you can squash them into one if you like. Most of the time my work builds up incrementally so it makes sense keeping the history (e.g. "implemented ...", then "engine: make use of ...", then "bla: enable ... globally") so each step could be reverted easily some day.

[jfeo]

Yes, I think I need to use a more structured approach in the future, instead of haphazardly adding everything and commiting :-P I'll just squash everything then.

[franciscod]

whtitespace

[boombatower]

Does this predate the python interface and need to be updated for that approach or is this ready to be built on? Debating using this in referencing issue.

[jfeo]

Hey @boombatower. I'm a bit unsure of what you mean by the python interface. I just pulled from master locally, and it works, so there's that :-) In regards to #11, I suppose it would make sense to perhaps use this as a base (perhaps make it more generic?).
Arbitrary sizes are already possible, like this:

[TheJJ]

Used in #559 and integrated in the qt ui.