Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ubuntu 22.04 to the build pipeline #1476

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

timo-a
Copy link
Contributor

@timo-a timo-a commented May 29, 2022

This PR adds a build on ubuntu 22.04 to the github workflows.
This PR is also evidence that #1474 is solved (I haven't tried to build locally though, only fiddled with the yml files).

@duanqn
Copy link
Contributor

duanqn commented May 30, 2022

Do you have a successful run for the new workflow somewhere?

duanqn
duanqn previously approved these changes May 30, 2022
@TheJJ
Copy link
Member

TheJJ commented May 30, 2022

thanks!
now that 22.04 works, i think we can remove 21.04, it won't be supported much longer anyway

@TheJJ TheJJ added improvement Enhancement of an existing component ci Related to our continuous integration systems (kevin, github-actions, ...) labels May 30, 2022
@duanqn
Copy link
Contributor

duanqn commented May 30, 2022

thanks! now that 22.04 works, i think we can remove 21.04, it won't be supported much longer anyway

Agreed. :)

@timo-a
Copy link
Contributor Author

timo-a commented May 30, 2022

Do you have a successful run for the new workflow somewhere?

Yes, over at my fork: https://github.com/timo-a/openage/actions/runs/2405696342

@timo-a
Copy link
Contributor Author

timo-a commented May 30, 2022

thanks! now that 22.04 works, i think we can remove 21.04, it won't be supported much longer anyway

Agreed. :)

I have removed 21.04 from the branch of the PR.
(most recent successful run is now https://github.com/timo-a/openage/actions/runs/2411215395)

@heinezen
Copy link
Member

@timo-a Great!

Can you also remove the references to old Ubuntu in the build instructions with your PR. Because we don't need those anymore :)

@duanqn
Copy link
Contributor

duanqn commented May 31, 2022

@timo-a Great!

Can you also remove the references to old Ubuntu in the build instructions with your PR. Because we don't need those anymore :)

You mean the Ubuntu 20.04 instructions?

@heinezen heinezen force-pushed the bump-ubuntu-to-22-04 branch from 5a20ffa to 30ce824 Compare June 1, 2022 10:26
Copy link
Member

@heinezen heinezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've squashed your changes for the Workflow creation. Looks good.

@heinezen heinezen merged commit 5237262 into SFTtech:master Jun 1, 2022
@heinezen
Copy link
Member

heinezen commented Jun 1, 2022

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to our continuous integration systems (kevin, github-actions, ...) improvement Enhancement of an existing component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants