Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -Wno-mismatched-tags flag for llvm builds #100

Merged
merged 1 commit into from
Nov 3, 2014
Merged

add -Wno-mismatched-tags flag for llvm builds #100

merged 1 commit into from
Nov 3, 2014

Conversation

zuntrax
Copy link
Contributor

@zuntrax zuntrax commented Nov 3, 2014

Fixes #89. Will supress useless warnings in the travis build. Flag is added for llvm only since gcc doesn't recognise it.

@zuntrax zuntrax added the area: buildsystem Related to our cmake/python buildsystem label Nov 3, 2014
@@ -210,6 +210,9 @@ if not flags and not ldflags:
flags.append("-flto=%d" % multiprocessing.cpu_count())
ldflags.append("-flto=%d" % multiprocessing.cpu_count())

if csuite in {'llvm'}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only runs if omode == 'max'

@TheJJ
Copy link
Member

TheJJ commented Nov 3, 2014

On my local machine (clang 3.5.0) this flag is not necessary, the build runs without any warning. This is some kind of travis issue i fear, and we should not add workarounds just for CI bugs.

@mic-e
Copy link
Member

mic-e commented Nov 3, 2014

I assume this is due to the ancient version of libstdc++ on travis. Unless travis will offer building on a more recent operating system very soon I opt for fixing it. Extra warnings clutter up the build log and make you miss actual warnings.

@franciscod
Copy link
Contributor

yeah, i neither have the warnings, but we are relying on the travis so let's merge this

@TheJJ
Copy link
Member

TheJJ commented Nov 3, 2014

👍 lookin good

mic-e added a commit that referenced this pull request Nov 3, 2014
add -Wno-mismatched-tags flag for llvm builds
@mic-e mic-e merged commit 129b49b into SFTtech:master Nov 3, 2014
schets added a commit to schets/openage that referenced this pull request Nov 12, 2014
add -Wno-mismatched-tags flag for llvm builds
inakoll added a commit to inakoll/openage that referenced this pull request Nov 24, 2014
add -Wno-mismatched-tags flag for llvm builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: buildsystem Related to our cmake/python buildsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The travis clang build has warnings
4 participants