Skip to content

feat: add support for custom base url filtering#3808

Open
louis-murray wants to merge 4 commits into
SFDO-Tooling:mainfrom
louis-murray:customUrlFilter
Open

feat: add support for custom base url filtering#3808
louis-murray wants to merge 4 commits into
SFDO-Tooling:mainfrom
louis-murray:customUrlFilter

Conversation

@louis-murray

Copy link
Copy Markdown

Background

When cumulusCI goes to execute a command against a specific org, it generates some config of the org. Part of the config is a lightningBaseUrl. The lightningBaseUrl composition tries to standardize the base url by setting the base url to *.lightning.force.com.

There are a few edge cases where the instance we're interacting with is using a wholly custom url format so a .lightning.force.com url isn't going to be accurate. In those cases, the .lightning.force.com url will cause robot actions to fail when trying to interact with the instance.

Resolution

In this PR, I introduce two env vars:

  • SF_CUSTOM_URL_RE - The shape of the url to match
  • SF_CUSTOM_URL_BASE - How to set the base url when the above matches

The config inflation will check if an org's url matches these env vars before defaulting to the .lightning.force.com base url.

@louis-murray louis-murray requested a review from a team as a code owner June 27, 2024 13:11
@salesforce-cla

Copy link
Copy Markdown

Thanks for the contribution! It looks like @louis-murray is an internal user so signing the CLA is not required. However, we need to confirm this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants