feat: add support for custom base url filtering#3808
Open
louis-murray wants to merge 4 commits into
Open
Conversation
|
Thanks for the contribution! It looks like @louis-murray is an internal user so signing the CLA is not required. However, we need to confirm this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When cumulusCI goes to execute a command against a specific org, it generates some config of the org. Part of the config is a
lightningBaseUrl. ThelightningBaseUrlcomposition tries to standardize the base url by setting the base url to*.lightning.force.com.There are a few edge cases where the instance we're interacting with is using a wholly custom url format so a
.lightning.force.comurl isn't going to be accurate. In those cases, the.lightning.force.comurl will cause robot actions to fail when trying to interact with the instance.Resolution
In this PR, I introduce two env vars:
SF_CUSTOM_URL_RE- The shape of the url to matchSF_CUSTOM_URL_BASE- How to set the base url when the above matchesThe config inflation will check if an org's url matches these env vars before defaulting to the
.lightning.force.combase url.