Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getNumberOfPassedChecks method #219

Open
martinmladenov opened this issue Jun 21, 2023 · 2 comments · May be fixed by #269
Open

Refactor getNumberOfPassedChecks method #219

martinmladenov opened this issue Jun 21, 2023 · 2 comments · May be fixed by #269
Assignees
@vesk4000
Labels
good first issue refactoring

Comments

@martinmladenov
Copy link
Collaborator

martinmladenov commented Jun 21, 2023 •
edited
Loading

The getNumberOfPassedChecks in CodeChecksResult method currently accepts a boolean.

One way to avoid this boolean would be to offer two methods weightedNumberOfPassedChecks.

See this blog post explaining this Clean Code rule: https://www.informit.com/articles/article.aspx?p=1392524

Originally posted by @mauricioaniche in #210 (comment)
@martinmladenov martinmladenov mentioned this issue Jun 21, 2023
Merged
@vesk4000
Copy link

vesk4000 commented Jul 5, 2023

I'd love to do this issue

@martinmladenov
Copy link
Collaborator Author

Thanks, I assigned you. Let me know if you have any questions :)

vesk4000 added a commit to vesk4000/andy that referenced this issue Sep 24, 2023
@vesk4000
Eliminated boolean arguments from getNumberOfPassedChecks and getTota…
717786b 
…lNumberOfChecks (Issue SERG-Delft#219)
@vesk4000 vesk4000 linked a pull request Sep 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vesk4000 vesk4000

Labels
good first issue refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eliminated Boolean Arguments From getNumberOfPassedChecks and getTotalNumberOfChecks vesk4000/andy
2 participants
@vesk4000 @martinmladenov