Skip to content

Commit

Permalink
libsemanage: avoid writing directly to stderr
Browse files Browse the repository at this point in the history 
The client application might have redirected the error output via
semanage_msg_set_callback(3), so use the logging macros.

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Acked-by: James Carter <jwcart2@gmail.com>
  • Loading branch information
@cgzones @jwcart2
cgzones authored and jwcart2 committed Nov 21, 2024
1 parent b592a3f commit bd2fd2c
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 33 deletions.
17 changes: 9 additions & 8 deletions libsemanage/src/direct_api.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1135,8 +1135,8 @@ static const int semanage_computed_files[] = {
/* Copies a file from src to dst. If dst already exists then
* overwrite it. If source doesn't exist then return success.
* Returns 0 on success, -1 on error. */
static int copy_file_if_exists(const char *src, const char *dst, mode_t mode){
int rc = semanage_copy_file(src, dst, mode, false);
static int copy_file_if_exists(semanage_handle_t *sh, const char *src, const char *dst, mode_t mode){
int rc = semanage_copy_file(sh, src, dst, mode, false);
return (rc < 0 && errno != ENOENT) ? rc : 0;
}

Expand Down Expand Up @@ -1431,7 +1431,7 @@ static int semanage_direct_commit(semanage_handle_t * sh)

path = semanage_path(SEMANAGE_TMP, SEMANAGE_SEUSERS_LINKED);
if (stat(path, &sb) == 0) {
retval = semanage_copy_file(path,
retval = semanage_copy_file(sh, path,
semanage_path(SEMANAGE_TMP,
SEMANAGE_STORE_SEUSERS),
0, false);
Expand All @@ -1449,7 +1449,7 @@ static int semanage_direct_commit(semanage_handle_t * sh)

path = semanage_path(SEMANAGE_TMP, SEMANAGE_USERS_EXTRA_LINKED);
if (stat(path, &sb) == 0) {
retval = semanage_copy_file(path,
retval = semanage_copy_file(sh, path,
semanage_path(SEMANAGE_TMP,
SEMANAGE_USERS_EXTRA),
0, false);
Expand Down Expand Up @@ -1558,28 +1558,28 @@ static int semanage_direct_commit(semanage_handle_t * sh)
if (retval < 0)
goto cleanup;

retval = semanage_copy_file(semanage_path(SEMANAGE_TMP, SEMANAGE_STORE_KERNEL),
retval = semanage_copy_file(sh, semanage_path(SEMANAGE_TMP, SEMANAGE_STORE_KERNEL),
semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_KERNEL),
sh->conf->file_mode, false);
if (retval < 0) {
goto cleanup;
}

retval = copy_file_if_exists(semanage_path(SEMANAGE_TMP, SEMANAGE_STORE_FC_LOCAL),
retval = copy_file_if_exists(sh, semanage_path(SEMANAGE_TMP, SEMANAGE_STORE_FC_LOCAL),
semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_FC_LOCAL),
sh->conf->file_mode);
if (retval < 0) {
goto cleanup;
}

retval = copy_file_if_exists(semanage_path(SEMANAGE_TMP, SEMANAGE_STORE_FC),
retval = copy_file_if_exists(sh, semanage_path(SEMANAGE_TMP, SEMANAGE_STORE_FC),
semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_FC),
sh->conf->file_mode);
if (retval < 0) {
goto cleanup;
}

retval = copy_file_if_exists(semanage_path(SEMANAGE_TMP, SEMANAGE_STORE_SEUSERS),
retval = copy_file_if_exists(sh, semanage_path(SEMANAGE_TMP, SEMANAGE_STORE_SEUSERS),
semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_SEUSERS),
sh->conf->file_mode);
if (retval < 0) {
Expand All @@ -1597,6 +1597,7 @@ static int semanage_direct_commit(semanage_handle_t * sh)
}
/* file_contexts.homedirs was created in SEMANAGE_TMP store */
retval = semanage_copy_file(
sh,
semanage_path(SEMANAGE_TMP, SEMANAGE_STORE_FC_HOMEDIRS),
semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_FC_HOMEDIRS),
sh->conf->file_mode, false);
Expand Down
44 changes: 22 additions & 22 deletions libsemanage/src/semanage_store.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ int semanage_store_access_check(void)

/********************* other I/O functions *********************/

static int semanage_copy_dir_flags(const char *src, const char *dst, int flag);
static int semanage_copy_dir_flags(semanage_handle_t * sh, const char *src, const char *dst, int flag);

/* Callback used by scandir() to select files. */
static int semanage_filename_select(const struct dirent *d)
Expand All @@ -670,8 +670,8 @@ static int semanage_filename_select(const struct dirent *d)

/* Copies a file from src to dst. If dst already exists then
* overwrite it. Returns 0 on success, -1 on error. */
int semanage_copy_file(const char *src, const char *dst, mode_t mode,
bool syncrequired)
int semanage_copy_file(semanage_handle_t *sh, const char *src, const char *dst,
mode_t mode, bool syncrequired)
{
int in, out, retval = 0, amount_read, n, errsv = errno;
char tmp[PATH_MAX];
Expand Down Expand Up @@ -725,7 +725,7 @@ int semanage_copy_file(const char *src, const char *dst, mode_t mode,
if (!retval && rename(tmp, dst) == -1)
return -1;

semanage_setfiles(dst);
semanage_setfiles(sh, dst);
out:
errno = errsv;
return retval;
Expand All @@ -741,23 +741,23 @@ static int semanage_rename(semanage_handle_t * sh, const char *src, const char *
/* we can't use rename() due to filesystem limitation, lets try to copy files manually */
WARN(sh, "WARNING: rename(%s, %s) failed: %m, fall back to non-atomic semanage_copy_dir_flags()",
src, dst);
if (semanage_copy_dir_flags(src, dst, 1) == -1) {
if (semanage_copy_dir_flags(sh, src, dst, 1) == -1) {
return -1;
}
return semanage_remove_directory(src);
}

/* Copies all of the files from src to dst, recursing into
* subdirectories. Returns 0 on success, -1 on error. */
static int semanage_copy_dir(const char *src, const char *dst)
static int semanage_copy_dir(semanage_handle_t * sh, const char *src, const char *dst)
{
return semanage_copy_dir_flags(src, dst, 1);
return semanage_copy_dir_flags(sh, src, dst, 1);
}

/* Copies all of the dirs from src to dst, recursing into
* subdirectories. If flag == 1, then copy regular files as
* well. Returns 0 on success, -1 on error. */
static int semanage_copy_dir_flags(const char *src, const char *dst, int flag)
static int semanage_copy_dir_flags(semanage_handle_t * sh, const char *src, const char *dst, int flag)
{
int i, len = 0, rc, retval = -1;
struct stat sb;
Expand All @@ -766,20 +766,20 @@ static int semanage_copy_dir_flags(const char *src, const char *dst, int flag)
mode_t mask;

if ((len = scandir(src, &names, semanage_filename_select, NULL)) == -1) {
fprintf(stderr, "Could not read the contents of %s: %s\n", src, strerror(errno));
ERR(sh, "Could not read the contents of %s.", src);
return -1;
}

if (stat(dst, &sb) != 0) {
mask = umask(0077);
if (mkdir(dst, S_IRWXU) != 0) {
umask(mask);
fprintf(stderr, "Could not create %s: %s\n", dst, strerror(errno));
ERR(sh, "Could not create %s.", dst);
goto cleanup;
}
umask(mask);

semanage_setfiles(dst);
semanage_setfiles(sh, dst);
}

for (i = 0; i < len; i++) {
Expand All @@ -801,15 +801,15 @@ static int semanage_copy_dir_flags(const char *src, const char *dst, int flag)
if (S_ISDIR(sb.st_mode)) {
mask = umask(0077);
if (mkdir(path2, 0700) == -1 ||
semanage_copy_dir_flags(path, path2, flag) == -1) {
semanage_copy_dir_flags(sh, path, path2, flag) == -1) {
umask(mask);
goto cleanup;
}
umask(mask);
semanage_setfiles(path2);
semanage_setfiles(sh, path2);
} else if (S_ISREG(sb.st_mode) && flag == 1) {
mask = umask(0077);
if (semanage_copy_file(path, path2, sb.st_mode,
if (semanage_copy_file(sh, path, path2, sb.st_mode,
false) < 0) {
umask(mask);
goto cleanup;
Expand Down Expand Up @@ -912,7 +912,7 @@ int semanage_mkdir(semanage_handle_t *sh, const char *path)

}
umask(mask);
semanage_setfiles(path);
semanage_setfiles(sh, path);
}
else {
/* check that it really is a directory */
Expand Down Expand Up @@ -956,7 +956,7 @@ int semanage_make_sandbox(semanage_handle_t * sh)

mask = umask(0077);
if (mkdir(sandbox, S_IRWXU) == -1 ||
semanage_copy_dir(semanage_path(SEMANAGE_ACTIVE, SEMANAGE_TOPLEVEL),
semanage_copy_dir(sh, semanage_path(SEMANAGE_ACTIVE, SEMANAGE_TOPLEVEL),
sandbox) == -1) {
umask(mask);
ERR(sh, "Could not copy files to sandbox %s.", sandbox);
Expand Down Expand Up @@ -1589,19 +1589,19 @@ static int semanage_validate_and_compile_fcontexts(semanage_handle_t * sh)
semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_FC)) != 0) {
goto cleanup;
}
semanage_setfiles(semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_FC_BIN));
semanage_setfiles(sh, semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_FC_BIN));

if (sefcontext_compile(sh,
semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_FC_LOCAL)) != 0) {
goto cleanup;
}
semanage_setfiles(semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_FC_LOCAL_BIN));
semanage_setfiles(sh, semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_FC_LOCAL_BIN));

if (sefcontext_compile(sh,
semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_FC_HOMEDIRS)) != 0) {
goto cleanup;
}
semanage_setfiles(semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_FC_HOMEDIRS_BIN));
semanage_setfiles(sh, semanage_final_path(SEMANAGE_FINAL_TMP, SEMANAGE_FC_HOMEDIRS_BIN));

status = 0;
cleanup:
Expand Down Expand Up @@ -1646,7 +1646,7 @@ static int semanage_install_final_tmp(semanage_handle_t * sh)
goto cleanup;
}

ret = semanage_copy_file(src, dst, sh->conf->file_mode,
ret = semanage_copy_file(sh, src, dst, sh->conf->file_mode,
true);
if (ret < 0) {
ERR(sh, "Could not copy %s to %s.", src, dst);
Expand Down Expand Up @@ -2994,7 +2994,7 @@ int semanage_nc_sort(semanage_handle_t * sh, const char *buf, size_t buf_len,

/* Make sure the file context and ownership of files in the policy
* store does not change */
void semanage_setfiles(const char *path){
void semanage_setfiles(semanage_handle_t * sh, const char *path){
struct stat sb;
int fd;
/* Fix the user and role portions of the context, ignore errors
Expand All @@ -3009,7 +3009,7 @@ void semanage_setfiles(const char *path){
!(S_ISREG(sb.st_mode) &&
(sb.st_mode & (S_ISUID | S_ISGID))) &&
(fchown(fd, 0, 0) == -1))
fprintf(stderr, "Warning! Could not set ownership of %s to root\n", path);
ERR(sh, "Warning! Could not set ownership of %s to root", path);

close(fd);
}
Expand Down
6 changes: 3 additions & 3 deletions libsemanage/src/semanage_store.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ int semanage_get_cil_paths(semanage_handle_t * sh, semanage_module_info_t *modin
int semanage_get_active_modules(semanage_handle_t *sh,
semanage_module_info_t **modinfo, int *num_modules);

void semanage_setfiles(const char *path);
void semanage_setfiles(semanage_handle_t * sh, const char *path);

/* lock file routines */
int semanage_get_trans_lock(semanage_handle_t * sh);
Expand Down Expand Up @@ -165,7 +165,7 @@ int semanage_nc_sort(semanage_handle_t * sh,
size_t buf_len,
char **sorted_buf, size_t * sorted_buf_len);

int semanage_copy_file(const char *src, const char *dst, mode_t mode,
bool syncrequired);
int semanage_copy_file(semanage_handle_t * sh, const char *src, const char *dst,
mode_t mode, bool syncrequired);

#endif

0 comments on commit bd2fd2c

Please sign in to comment.