authlogin: guard dbus_system_bus_client calls with optional_policy#1139
Open
thesamesam wants to merge 3 commits into
Open
authlogin: guard dbus_system_bus_client calls with optional_policy#1139thesamesam wants to merge 3 commits into
thesamesam wants to merge 3 commits into
Conversation
Contributor
Author
|
I don't yet understand why the sudo commit failed CI. The first commit is the only important one though. Feel free to cherry-pick that. |
Member
If init_systemd is disabled, the optional block is empty. I'd say move the rules out of the ifdef. If you have a systemd module, that's a good enough indicator to enable systemd rules. |
Contributor
Author
|
Thanks, duh.. |
…ith optional_policy The dbus policy may not be installed (yet) when installing the systemd module (for the first time). Note that it is possible I believe to use systemd w/o DBus at all but it's quite rare. Bug: https://bugs.gentoo.org/975996 Signed-off-by: Sam James <sam@gentoo.org>
We need optional_policy here because the dbus policy may not (yet) be available. Be consistent with other uses. Just use optional_policy w/ no ifdef because when systemd is disabled, we'd have an optional_policy that is empty otherwise. Signed-off-by: Sam James <sam@gentoo.org>
Just noticed when checking calls for another problem in authlogin. Signed-off-by: Sam James <sam@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dbus policy may not be installed (yet) when installing the systemd
module (for the first time).
Note that it is possible I believe to use systemd w/o DBus at all but
it's quite rare.
Bug: https://bugs.gentoo.org/975996
Signed-off-by: Sam James sam@gentoo.org