Skip to content

xserver: fixup labelling for mesa cache #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

xserver: fixup labelling for mesa cache #1038

wants to merge 1 commit into from

Conversation

@WavyEbuilder
Copy link
Contributor

@WavyEbuilder WavyEbuilder commented Nov 3, 2025

No description provided.

@WavyEbuilder WavyEbuilder marked this pull request as ready for review November 3, 2025 02:18
@WavyEbuilder
Copy link
Contributor Author

WavyEbuilder commented Nov 3, 2025 •
edited
Loading

Added links to where the directories are from to the commit description and also labelled the single file directory. The name is kind of confusing, but it is indeed a directory not a file, see:
https://gitlab.freedesktop.org/mesa/mesa/-/blob/5d92c92ce56c4c3b9d98936fee51129281923e1a/src/util/disk_cache_os.c#L907
https://gitlab.freedesktop.org/mesa/mesa/-/blob/5d92c92ce56c4c3b9d98936fee51129281923e1a/src/util/disk_cache_os.c#L924

I also decided to split apart the _db and _sf into separate lines instead of relying on optional regex groups so it looks a bit cleaner, I'm happy to merge them back into one but it's a bit unwieldy to read.

@WavyEbuilder
xserver: fixup labelling for mesa cache
a28fb48 
Label mesa_shader_cache_db[1][2], mesa_shader_cache_sf[3][4] and
radv_builtin_shaders[5] as mesa_shader_cache_t.

[1] https://gitlab.freedesktop.org/mesa/mesa/-/blob/5d92c92ce56c4c3b9d98936fee51129281923e1a/docs/envvars.rst#L263-266
[2] https://gitlab.freedesktop.org/mesa/mesa/-/blob/5d92c92ce56c4c3b9d98936fee51129281923e1a/src/util/disk_cache.h#L48
[3] https://gitlab.freedesktop.org/mesa/mesa/-/blob/5d92c92ce56c4c3b9d98936fee51129281923e1a/docs/envvars.rst#L219-232
[4] https://gitlab.freedesktop.org/mesa/mesa/-/blob/5d92c92ce56c4c3b9d98936fee51129281923e1a/src/util/disk_cache.h#L47
[5] https://gitlab.freedesktop.org/mesa/mesa/-/blob/5d92c92ce56c4c3b9d98936fee51129281923e1a/src/amd/vulkan/radv_physical_device.c#L2495

Signed-off-by: Rahul Sandhu <nvraxn@gmail.com>
@WavyEbuilder
Copy link
Contributor Author

WavyEbuilder commented Nov 3, 2025 •
edited
Loading

I think it might be nice to in the future move this out of xserver into another module as we noted in the Wayland patch earlier, any suggestions for existing ones? Could do the userdomain or the xdg module as it is just labelling? I'm slightly averse to creating a new mesa module just for this as there is a lot of stuff (e.g. fonts) and future things that will need labelling, so ideally whatever we go with we can put other user home dir related labelling in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@WavyEbuilder