Skip to content

Support AnimatedImage on watchOS - Using WatchKit bridge #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 21, 2019
Merged

Support AnimatedImage on watchOS - Using WatchKit bridge #22

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
bfb48ac
Temp for watchOS AnimatedImage support, using massive private API, st…
dreampiggy Oct 6, 2019
80d2510
Update the hack for wacthKit experienment, fix the retain cycle issue…
dreampiggy Oct 11, 2019
9d5d5fd
Solve the merge conflict and try again
dreampiggy Oct 19, 2019
33fb3d3
Add support for contentMode
dreampiggy Oct 19, 2019
7f94bf6
Fix the SDAnimatedImageInterface first appear shows empty issues
dreampiggy Oct 19, 2019
cf588c8
Fix the scale factor support for SDAniamtedImageInterface
dreampiggy Oct 19, 2019
4736821
Fix the compile issue on other platforms
dreampiggy Oct 19, 2019
8441718
Merge branch 'master' of https://github.com/SDWebImage/SDWebImageSwif…
dreampiggy Oct 20, 2019
ab7a54c
Stop animtiong when dismantle for watchOS AnimatedImage
dreampiggy Oct 20, 2019
dfb9ab4
Fix the issue that stopAnimating does not stop :)
dreampiggy Oct 21, 2019
f1af6c2
Fix the warning because of Apple's bug
dreampiggy Oct 21, 2019
bdbf0a5
Use macro to integrate the watchOS Animation solution
dreampiggy Oct 21, 2019
a9fa353
Refactory code to fix that calling sd_setImage(with:) multiple times …
dreampiggy Oct 21, 2019
e456b38
Support to custom loop count on watchOS AnimatedImage
dreampiggy Oct 21, 2019
95bfc40
Fix the CocoaPods issues which does not have umbrella headers
dreampiggy Oct 21, 2019
73a9ff0
Update some of the documentations
dreampiggy Oct 21, 2019
30bc73f
Try to solve the SwiftPM issue because it does not support mixed Obje…
dreampiggy Oct 21, 2019
2e9af2f
Fix travis CI script to only build Carthage. Swift cli build can not …
dreampiggy Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the issue that stopAnimating does not stop :)
  • Loading branch information
@dreampiggy
dreampiggy committed Oct 21, 2019
commit dfb9ab4a8484bbfb140bad1fe7d10d78488e1230
2 changes: 1 addition & 1 deletion SDWebImageSwiftUI/Classes/SDAnimatedImageInterface.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ - (void)startAnimatingWithImagesInRange:(NSRange)imageRange duration:(NSTimeInte

- (void)stopAnimating {
if (self.animatedImage) {
self.currentStatus.shouldAnimate = YES;
self.currentStatus.shouldAnimate = NO;
} else if (_image.images.count > 0) {
[super stopAnimating];
}
Expand Down