Supports onSuccess/onFailure/onProgress callback for WebImage/AnimatedImage #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Image, make it possible to notify result
dreampiggy
commented
Oct 3, 2019
| @@ -178,17 +189,10 @@ public struct AnimatedImage : ViewRepresentable { | |||
| view.setNeedsDisplay() | |||
| #endif | |||
| } | |||
|
|
|||
| public func image(_ image: PlatformImage?) -> Self { | |||
There was a problem hiding this comment.
Wrong API design. The WebImage and AnimatedImage should be immutable struct. If we want to change image, refresh the View Tree to provide another struct. Just like SwiftUI's tutorial or some other declarative framework (Flutter, React for example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These event callback is important for advanced usage, like current progress indicator implementation in our Demo.
One more tips:
Currently, the
WebImageandAnimatedImageneed to write twice code, because of the implementation detail, maybe in the future we can refactory with the sameless solution.WebIamge: Using the SDWebImageManger APIAnimartedImage: Using the SDAnimatedImage+WebCache API