Skip to content
This repository was archived by the owner on Aug 3, 2022. It is now read-only.

Adopt SDWebImage's memory cache cost function, fix the nullable issue #7

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

dreampiggy
Copy link
Collaborator

See SDWebImage/SDWebImage#2568

This PR add the memory cache cost function for custom image class SDFLAnimatedImage. Which is a wrapper for FLAnimatedImage. It store a internal frame buffer (called window) with a limit size.

@dreampiggy dreampiggy force-pushed the feature_cache_cost_function branch from 0434d3f to 05bf304 Compare January 3, 2019 07:56
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #7 into master will decrease coverage by 6.59%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #7     +/-   ##
=========================================
- Coverage   77.77%   71.18%   -6.6%     
=========================================
  Files           2        2             
  Lines         108      118     +10     
=========================================
  Hits           84       84             
- Misses         24       34     +10
Flag Coverage Δ
#iOS 71.18% <0%> (-6.6%) ⬇️
Impacted Files Coverage Δ
.../Classes/FLAnimatedImageBridge/SDFLAnimatedImage.m 66.19% <0%> (-10.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e351c1d...13dea7a. Read the comment docs.

@dreampiggy dreampiggy force-pushed the feature_cache_cost_function branch from 05bf304 to 13dea7a Compare January 8, 2019 05:01
@dreampiggy dreampiggy merged commit f96c019 into master Jan 8, 2019
@dreampiggy dreampiggy deleted the feature_cache_cost_function branch January 15, 2019 06:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant