-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
This changes need to wait SDWebImage/SDWebImage#2453 to be merged in. So that we can keep the However, since this option are actually rare for most of usage, even that PR is not merged in, I think this solution is still better than the previous custom coder solution. Because now it don't need a extra coder, and make the |
Example/Podfile
Outdated
@@ -3,6 +3,7 @@ inhibit_all_warnings! | |||
|
|||
target 'SDWebImageFLPlugin_Example' do | |||
pod 'SDWebImageFLPlugin', :path => '../' | |||
pod 'SDWebImage/Core', :path => '../../SDWebImage' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't want to add this, it will not work. Also breaks the CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bpoplauschi It's local podfile because I test it locally to ensure it works. But that SDWebImage/SDWebImage#2453 (comment) was not been merged when this PR was created.
Now I can specify the branch dependency and update podfile.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the Podfile
change, looks good. Waiting for SDWebImage/SDWebImage#2453 to be merged
Supports custom extra initializer args for FLAnimatedImage
a04be4a
to
74692f2
Compare
Waiting for CI |
Opps...The CI have a Later I will also move the test case into this repo. |
Never mind. I can merge it as it is, it will work when we release a new version. |
Changes
The previous version (0.2.0), use a
SDWebImageFLCoder
custom coder, to create custom FLAnimatedImage for category. However, since it need extra config after import this plugin (not so out-of-box), and the associated object way of creatingUIImage which represent FLAnimatedImage
is not so convient. So this PR use another solution, by using Animated Image Customization.Solution
This PR create a subclass of
UIImage
calledSDFLAnimatedImage
, and it conforms toSDAnimatedImage
protocol. So ourFLAnimatedImage+WebCache
does not need any extra config, the wrapper class should be used to create and represent a actualFLAnimatedImage
.And it's now more easy to use, because you know that
SDFLAnimatedImage
is always GIF representation. So that it can be easy to detect and debug.