Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authorization-ClassicAdminCalls.json #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhenglaizhang
Copy link

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-bot
Copy link

openapi-pipeline-bot bot commented Nov 13, 2020

Swagger Validation Report

️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️~[Staging] Avocado succeeded [Detail] [Expand]
️️✔️~[Staging] SemanticValidation succeeded [Detail] [Expand]
️️✔️~[Staging] ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Rule Message
1008 - ModifiedOperationId The operation id has been changed from 'ClassicAdministrators_List' to 'ClassicAdministrators_ListABCD'. This will impact generated code.
New: Microsoft.Authorization/stable/2015-07-01/authorization-ClassicAdminCalls.json#L38:7
Old: Microsoft.Authorization/stable/2015-07-01/authorization-ClassicAdminCalls.json#L38:7
️️✔️~[Staging] LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.

Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-bot
Copy link

openapi-pipeline-bot bot commented Nov 13, 2020

Swagger Generation Artifacts

️️✔️~[Staging] ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️🔄~[Staging] SDK azure-sdk-for-java inProgress [Detail]
️🔄~[Staging] SDK azure-sdk-for-python inProgress [Detail]
️️✔️~[Staging] SDK azure-resource-manager-schemas succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 28c42f6d3f6d8075c5c5c0247eadf700cf4fc2ec. Schema Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	autorest --use=@autorest/azureresourceschema@3.0.86 --version=3.0.6318 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/w/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
    cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
    cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
    cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
    cmdout	[Autorest] WARNING: Skipping path '/{roleAssignmentId}': Unable to locate '/providers/' segment
    cmdout	[Autorest] WARNING: Skipping path '/{roleAssignmentId}': Unable to locate '/providers/' segment
  • ️✔️authorization [View full logs]  [Preview Schema Changes]
    cmderr	[resource-manager] node-pre-gyp
    cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
    cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
    cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules/fsevents):
    cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
️🔄~[Staging] SDK azure-sdk-for-go inProgress [Detail]
️🔄~[Staging] SDK azure-sdk-for-net inProgress [Detail]
️🔄~[Staging] SDK azure-sdk-for-js inProgress [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant