Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cdn.json #26

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Update cdn.json #26

merged 1 commit into from
Sep 28, 2020

Conversation

zhenglaizhang
Copy link

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-bot
Copy link

openapi-pipeline-bot bot commented Sep 28, 2020 •
edited
Loading

Swagger Generation Artificats

️️✔️~[Staging] SDK azure-sdk-for-java succeeded [Detail]
️️✔️~[Staging] SDK azure-sdk-for-python succeeded [Detail]
️️✔️~[Staging] SDK azure-sdk-for-js succeeded [Detail]
️️✔️~[Staging] SDK azure-resource-manager-schemas succeeded [Detail]
️️✔️~[Staging] SDK azure-sdk-for-net succeeded [Detail]
️❌~[Staging] SDK azure-sdk-for-go failed [Detail] [Expand]
  • ❌ Generate from 24ede7d with merge commit e5697c7. SDK Automation 13.0.1702 
    [AutoRest] FATAL: System.InvalidOperationException: output-folder /z/work/src/github.com/Azure/azure-sdk-for-go/services/preview/cdn/mgmt/2020-04-15/cdn of tag package-2020-04 must not be under a preview subdirectory for a stable swagger set. Please refer the sample for readme.go.md file here https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/samplefiles/readme.go.md for more information
    [AutoRest]    at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 187
    [AutoRest]    at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
    [AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
    [AutoRest] FATAL: go/generate - FAILED
    [AutoRest] FATAL: Error: Plugin go reported failure.
    [AutoRest] Failure during batch task - {'tag':'package-2020-04'} -- Error: Plugin go reported failure..
    [AutoRest]   Error: Plugin go reported failure.
    Failed to run autorest.
    Error: /z/node_modules/.bin/autorest --use=@microsoft.azure/autorest.go@~2.1.155 --go --verbose --multiapi --use-onever --preview-chk --version=V2 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/cdn/resource-manager/readme.md FATAL: System.InvalidOperationException: output-folder /z/work/src/github.com/Azure/azure-sdk-for-go/services/preview/cdn/mgmt/2020-04-15/cdn of tag package-2020-04 must not be under a preview subdirectory for a stable swagger set. Please refer the sample for readme.go.md file here https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/samplefiles/readme.go.md for more information
       at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 187
       at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
       at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
    FATAL: go/generate - FAILED
    FATAL: Error: Plugin go reported failure.
    Failure during batch task - {'tag':'package-2020-04'} -- Error: Plugin go reported failure..
      Error: Plugin go reported failure.
    , {} 
    Failed to find any diff after autorest so no changed packages was found.
Posted by Swagger Pipeline | How to fix these errors?

@wh02-prototype
Copy link

In Testing, Please Ignore

This was referenced Sep 28, 2020
Closed
Closed
Closed
@zhenglaizhang zhenglaizhang merged commit e5697c7 into master Sep 28, 2020
@wh02-prototype
Copy link

In Testing, Please Ignore

3 similar comments
@wh02-prototype
Copy link

In Testing, Please Ignore

@wh02-prototype
Copy link

In Testing, Please Ignore

@wh02-prototype
Copy link

In Testing, Please Ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhenglaizhang