Fixes to Integration #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Joshua-Kloepfer
commented
Sep 30, 2025
Joshua-Kloepfer
commented
- Created test called testIntegrator to test triangles and tetrahedron with shape order one and two.
- Added documentation regarding the ordering of nodes required for integration.
- Corrected flawed values in integration points.
cwsmith
requested changes
Oct 1, 2025
docs/Ordering.tex
Outdated
| \filldraw[black] (2.5, 2.5) circle (2pt) node[anchor=south]{V2}; | ||
| \end{tikzpicture} | ||
| \\ | ||
| Any Counter clockwise ordering is fine ie: V0, V1, V2 and V2, V0, V1.\\ |
There was a problem hiding this comment.
I think we should remove the text describing what alternatives could work and just document the one that we currently use.
| \filldraw[black] (0, 2.5, 0) circle (2pt) node[anchor=south]{E5}; | ||
| \end{tikzpicture} | ||
| \\ | ||
| Vertex ordering must follow right hand rule and edge ordering must follow diagram. |
There was a problem hiding this comment.
I think we should keep this comment/text.
I think we should wait until we add further tests to make sure that everything is working before adding to main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.