Skip to content

Conversation

@wrtobin
Copy link
Collaborator

@wrtobin wrtobin commented Jul 3, 2019

move the implementation of NoSharing to be with the other sharing types

change it to be a singleton (which I usually hate but is actually warranted because NoSharing is basically just a stateless functor and we only ever need to retrieve a pointer to it externally)

modify countEntitiesOfType to allow counting based on Sharings without changing the API semantics

add two tests to the test suite to test both a serial and partitioned mesh

…gleton because it is effectively a state-less functor, and modify countEntitiesOfType to allow counting based on Sharings without changing the API semantics
@wrtobin wrtobin requested a review from cwsmith July 3, 2019 16:05
@wrtobin
Copy link
Collaborator Author

wrtobin commented Jul 3, 2019

@cwsmith This PR should be fine to merge pretty much immediately.

@wrtobin
Copy link
Collaborator Author

wrtobin commented Jul 3, 2019

I'm actually going to add two API utility functions: countLocalNodes() and countGlobalNodes(), using this new functionality, so I'll add that in and add a test as well in a moment.

…node counts for fields, or just meshes with fieldshapes, also adding basic testing of the functions
@wrtobin
Copy link
Collaborator Author

wrtobin commented Jul 3, 2019

@cwsmith That should wrap up this PR in terms of code additions.

You want me to squash the commits into a single commit?

@cwsmith
Copy link
Contributor

cwsmith commented Jul 3, 2019

@wrtobin Looks good. I'm fine without the squash; its up to you.

@wrtobin
Copy link
Collaborator Author

wrtobin commented Jul 3, 2019

Okay I'll just merge it in that case, I want to create another small PR today and it's easier if this is in develop.

@wrtobin wrtobin merged commit 4affaea into master Jul 3, 2019
@wrtobin
Copy link
Collaborator Author

wrtobin commented Jul 3, 2019

Well, like a dummy I apparently set up this PR on master instead of develop.

Whats the easiest procedure to roll this back and get it in develop?

@wrtobin
Copy link
Collaborator Author

wrtobin commented Jul 3, 2019

Okay I merged a revert PR to master, glad GitHub has that. I'll make a new PR for the branch to go to develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants