copy constructors for apf::mesh and apf::Numbering

[jacobmerson]

I need to copy a mesh and numbering.

I did not find a convenient way of copying an apf numbering. Does anything exist? Or should I implement something and submit a pull request?

For the mesh I can use apf::createMdsMesh(model, mesh) which works for my use case, however it seems like there should be a function apf::copyMesh which either does the same, or copies all of the underlying fields as well.

[cwsmith]

Does the copied numbering need to exist on the copied mesh or on the original mesh?

If the new numbering is needed on the copied mesh than convert:

core/apf/apfConvert.h

Lines 23 to 28 in 5198f7d

	/** \brief convert one mesh data structure to another
	\details this function will fill in a structure that fully
	implements apf::Mesh2 by using information from an implementation
	of apf::Mesh. This is a fully scalable parallel mesh conversion
	tool. */
	void convert(Mesh *in, Mesh2 *out);

should work. Note, I have only seen this used for mds -> simmetrix, but it should work fine for mds -> mds.

[jacobmerson]

I tried using the convert function which seems to crash because my mesh already has fields on it e.g.
convert calls:

core/apf/apf.cc

Lines 124 to 128 in d2fbb26

	Field* cloneField(Field* f, Mesh* onto)
	{
	return makeField(onto, f->getName(), f->getValueType(), f->countComponents(),
	f->getShape(), f->getData()->clone());
	}

which in turn calls:

core/apf/apfFieldData.cc

Lines 13 to 16 in d2fbb26

	FieldData* FieldData::clone()
	{
	abort();
	}

Is there a known work around?

[cwsmith]

I'm not sure why clone is not implemented. @TobinW, any insight into this? Assuming there are no gotcha's implementing it would be the 'right' thing to do.

It looks like the conversion functions for numberings:

core/apf/apfConvert.cc

Line 168 in 3c004b6

void convertNumbering(Numbering* in, Numbering* out)

is a simple iteration over the mesh entities and should work.

[wrtobin]

No idea why FieldData::clone() is unimplemented offhand other than it hasn't been needed yet possibly.

I can definitely take a look at this later in the week but I'm currently recovering from a wrist injury which makes typing take FOREVER.

[jacobmerson]

I need this to move forward with what I am working on, so I will implement and submit a pull request.

[jacobmerson]

As a note for something that needs to be fixed before this gets closed. The convertNumbering and convertGlobalNumbering functions do not properly set the field of the numbering.

core/apf/apfConvert.cc

Lines 168 to 212 in d2fbb26

	void convertNumbering(Numbering* in, Numbering* out)
	{
	FieldShape* s = getShape(in);
	int nc = countComponents(in);
	for (int d = 0; d <= 3; ++d)
	{
	if (s->hasNodesIn(d))
	{
	MeshIterator* it = inMesh->begin(d);
	MeshEntity* e;
	while ((e = inMesh->iterate(it)))
	{
	int nn = s->countNodesOn(inMesh->getType(e));
	for (int i = 0; i < nn; ++i)
	{
	for (int j = 0; j < nc; ++j) {
	number(out, newFromOld[e], i, j,
	getNumber(in, e, i, j));
	}
	}
	}
	inMesh->end(it);
	}
	}
	}
	void convertGlobalNumbering(
	GlobalNumbering* in, GlobalNumbering* out)
	{
	FieldShape* s = getShape(in);
	int nc = countComponents(in);
	PCU_DEBUG_ASSERT(nc == 1);
	for (int d = 0; d <= 3; ++d) {
	if (s->hasNodesIn(d)) {
	MeshIterator* it = inMesh->begin(d);
	MeshEntity* e;
	while ((e = inMesh->iterate(it))) {
	int nn = s->countNodesOn(inMesh->getType(e));
	for (int i = 0; i < nn; ++i)
	number(out, newFromOld[e], i,
	getNumber(in, e, i, 0));
	}
	inMesh->end(it);
	}
	}
	}

[jacobmerson]

Also, the convert function does not deal with tags. I will add in this functionality to my pull request tomorrow.