Fix lat-to-lon aspect ratio (now for real) #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #125 (comment), the calculation of the aspect ratio for the 'fast' projection plotting option was still not correct. This PR fixes this.
To summarize:
1 / (LATKM / 111.320 * np.cos(np.deg2rad(lat_region)))
-- WRONG (but almost correct)111.320 * np.cos(np.deg2rad(lat_region)) / LATKM
-- VERY WRONG111.320 / LATKM / np.cos(np.deg2rad(lat_region))
-- WRONG (but almost correct)LATKM / (111.320 * np.cos(np.deg2rad(lat_region)))
Apologies for the multiple confusions! Next time, I will do the maths first... 😉