Skip to content

Fix lat-to-lon aspect ratio (now for real) #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

mherrmann3
Copy link
Contributor

As noted in #125 (comment), the calculation of the aspect ratio for the 'fast' projection plotting option was still not correct. This PR fixes this.

To summarize:

Apologies for the multiple confusions! Next time, I will do the maths first... 😉

@codecov-commenter
Copy link

Codecov Report

Merging #127 (6583bcb) into master (e2bfd9b) will not change coverage.
The diff coverage is n/a.

❗ Current head 6583bcb differs from pull request most recent head 97a5715. Consider uploading reports for the commit 97a5715 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   57.12%   57.12%           
=======================================
  Files          19       19           
  Lines        3142     3142           
  Branches      452      452           
=======================================
  Hits         1795     1795           
  Misses       1237     1237           
  Partials      110      110           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2bfd9b...97a5715. Read the comment docs.

@wsavran
Copy link
Collaborator

wsavran commented Jun 22, 2021

looks good @mherrmann3 ! i can take partial responsibility for missing this as well. ive checked this and it now looks ok. merging this PR!

@wsavran wsavran merged commit 17a1ba2 into SCECcode:master Jun 22, 2021
@mherrmann3 mherrmann3 deleted the fix_lat_lon_aspect branch June 22, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants