Fixes bug where falsy choice values incorrectly take the choice name. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, great solution too. I'll publish with next release! |
SBoudrias
added a commit
that referenced
this pull request
Feb 23, 2014
Fixes bug where falsy choice values incorrectly take the choice name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choices with falsy values cause the value to take-on the name, which (IMHO) is not expected.
In my use-case, I would like to use numbers (including zero) as values.
I could imagine using null or undefined as values too, depending on the situation.
This patch makes such things possible.
This fix might cause issues for existing users if they were relying on the existing behaviour.