Skip to content

Conversation

@SabrinaBrickner
Copy link

Description

Adds 5 files to the MevPrtl generator. 3 of these files are the fcls needed to run the new set of LLP modules, and the other 2 files contain the output of running the fcls with the new LLP tools.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Yes -> in sbncode it requires "MeVPrtl LLP (tools)"

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@SabrinaBrickner SabrinaBrickner self-assigned this Oct 7, 2025
@SabrinaBrickner SabrinaBrickner added the enhancement New feature or request label Oct 7, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove from commit to avoid ROOT files in the repository

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove from commit to avoid ROOT files in the repository



#DECAY CONFIGS
decay_llp: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment stating that the decay part is still work in progress and is not meant to be used (I see there are a lot of HNL-specific parameters there).

@nathanielerowe
Copy link
Contributor

@SabrinaBrickner Could you respond to some of these follow up q's?

@jicrespo
Copy link
Member

For the record, this is an ongoing review and it is not required to converge for the Fall Production. @GaetanoFricano is also working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants