-
Notifications
You must be signed in to change notification settings - Fork 53
CRT Calibration Database Interface #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
henrylay97
wants to merge
19
commits into
develop
Choose a base branch
from
feature/hlay_crt_calibration_database_interface
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CRT Calibration Database Interface #839
henrylay97
wants to merge
19
commits into
develop
from
feature/hlay_crt_calibration_database_interface
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nterface Version v10_10_03_02
…_calibration_database_interface
|
Just a heads up, sbnd_data has a repo now so you should be able to make a PR when your stuff is ready. |
lucykotsiopoulou
approved these changes
Oct 29, 2025
linyan-w
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Significant amount of work! Thank you so much Henry and Lucy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
calibration
calib ntuple or calib workflow related
crt
Cosmic Ray Tagger
enhancement
New feature or request
maintenance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes old calibration service that read text files and replace with new service, modelled on the PMT one, that uses the calibration database as requested. For now there is still a single value for each parameter but others are working on getting time/run dependency available.
A lot of fcl changes are made to cope with this.
I have also taken the opportunity to move a lot more functionality into the
CRTChannelMapServiceto avoid many algorithms doing their own constructions of channel IDs.The database files are added via SBNSoftware/sbnd_data#2
This PR will resolve #770.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
SBNSoftware/sbnd_data#2
Link(s) to docdb describing changes (optional)
N/A