Skip to content

Conversation

@henrylay97
Copy link
Member

@henrylay97 henrylay97 commented Oct 2, 2025

Description

Removes old calibration service that read text files and replace with new service, modelled on the PMT one, that uses the calibration database as requested. For now there is still a single value for each parameter but others are working on getting time/run dependency available.

A lot of fcl changes are made to cope with this.

I have also taken the opportunity to move a lot more functionality into the CRTChannelMapService to avoid many algorithms doing their own constructions of channel IDs.

The database files are added via SBNSoftware/sbnd_data#2

This PR will resolve #770.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

SBNSoftware/sbnd_data#2

Link(s) to docdb describing changes (optional)

N/A

@henrylay97 henrylay97 self-assigned this Oct 2, 2025
@henrylay97 henrylay97 added enhancement New feature or request maintenance crt Cosmic Ray Tagger calibration calib ntuple or calib workflow related labels Oct 2, 2025
@henrylay97 henrylay97 changed the base branch from feature/hlay_crt_geo_alg_service to develop October 14, 2025 15:22
@nathanielerowe
Copy link
Contributor

Just a heads up, sbnd_data has a repo now so you should be able to make a PR when your stuff is ready.

@henrylay97 henrylay97 marked this pull request as ready for review October 28, 2025 11:03
Copy link
Contributor

@linyan-w linyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Significant amount of work! Thank you so much Henry and Lucy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

calibration calib ntuple or calib workflow related crt Cosmic Ray Tagger enhancement New feature or request maintenance

Projects

Development

Successfully merging this pull request may close these issues.

CRT Calibration Database Usage

5 participants