Feature/sungbino likepid into cafmaker #593

sungbinoh · 2025-10-20T16:54:16Z

Description

Updating CAF making codes to add likelihood-based PID variables.

sbncode/CAFMaker/CAFMakerParams.h: a new label TrackLikePidLabel
sbncode/CAFMaker/FillReco.cxx/h: adding FillTrackLikePID and FillPlaneLikePID. They have almost the same shape with FillTrackChi2PID and FillPlaneChi2PID but uses Likelihood (larana link) as input and SRTrkLikePID (sbnanaobj PR link) as output.
sbncode/CAFMaker/CAFMaker_module.cc: adding art::FindManyP<anab::ParticleID> fmLikePID and calling FillTrackLikePID

Please note that

Reconstruction related fcl files should be updated for each of icaruscode and sbndcode to measure likelihood PID variables. Examples in sbndcode can be found in PR849.
Cafmaker fcl files should be updated in either of icaruscode and sbndcode too to assign correct fmLikePID.
Have you added a label? (bug/enhancement/physics etc.)
Have you assigned at least 1 reviewer?
Is this PR related to an open issue / project?
Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.

Yes. PR 168 in sbnanaobj should be merged first.

Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

henrylay97

Looks fine to me! Thanks @sungbinoh.

One small q.

henrylay97 · 2025-10-21T14:23:32Z

sbncode/CAFMaker/FillReco.cxx

+    srlikepid.lambda_muon = 0.;
+    srlikepid.lambda_pion = 0.;
+    srlikepid.lambda_proton = 0.;
+    srlikepid.pid_ndof = 0;


Why do we change from the previous defaults here?

The object fills the defaults as -5

Hi @henrylay97 ,
Thank you for the review!
That is a good catch. I did kind of no-brain copy of chi2pid part.
I agree that the default value should be distinguishable from the actual values.
Updating default values for lambdas to -9999. and ndof to -5!

henrylay97

Thanks Sungbin. Another comment on defaults (sorry!). Also not sure that this will run currently? Looks like we're passing a SRTrack rather than an SRTrkLikelihoodPID to the function?

sbncode/CAFMaker/CAFMaker_module.cc

henrylay97 · 2025-10-23T08:58:33Z

sbncode/CAFMaker/FillReco.cxx

+    srlikepid.lambda_pion = -9999.;
+    srlikepid.lambda_proton = -9999.;
+    srlikepid.pid_ndof = -5;
+


I would remove this completely.

The values will be set to be the defaults by the default constructor anyway so let's avoid multiple points of maintenance. (See my comment here for more thoughts SBNSoftware/sbnanaobj#168 (comment))

Hi @henrylay97 , I've removed these lines following your comment in the SBNSoftware/sbnanaobj#168 (comment). Thank you!

henrylay97

Thanks for responding so quick. I'm happy with this now 😀

sbncode/CAFMaker/CAFMaker_module.cc

PetrilloAtWork

I have left some coding comments.
The changes to avoid copies are required, while the coding style ones are up to you.

PetrilloAtWork · 2025-10-24T00:43:08Z

sbncode/CAFMaker/FillReco.h

                        caf::SRTrack& srtrack,
                        bool allowEmpty = false);
+  void FillPlaneLikePID(const anab::ParticleID &particle_id, caf::SRTrkLikelihoodPID &srlikepid);
+  void FillTrackLikePID(const std::vector<art::Ptr<anab::ParticleID>> particleIDs,


You forgot the reference:

Suggested change

void FillTrackLikePID(const std::vector<art::Ptr<anab::ParticleID>> particleIDs,

void FillTrackLikePID(const std::vector<art::Ptr<anab::ParticleID>>& particleIDs,

PetrilloAtWork · 2025-10-24T00:46:07Z

sbncode/CAFMaker/FillReco.cxx

+    }
+  }
+
+  void FillTrackLikePID(const std::vector<art::Ptr<anab::ParticleID>> particleIDs,


Pass the particle ID pointer objects by reference ([CF-112]):

Suggested change

void FillTrackLikePID(const std::vector<art::Ptr<anab::ParticleID>> particleIDs,

void FillTrackLikePID(const std::vector<art::Ptr<anab::ParticleID>>& particleIDs,

PetrilloAtWork · 2025-10-24T00:50:51Z

sbncode/CAFMaker/FillReco.cxx

+    for (unsigned i = 0; i < particleIDs.size(); i++) {
+      const anab::ParticleID &particle_id = *particleIDs[i];


You can compact this avoiding i:

Suggested change

for (unsigned i = 0; i < particleIDs.size(); i++) {

const anab::ParticleID &particle_id = *particleIDs[i];

for (art::Ptr<anab::ParticleID> const& pidPtr: particleIDs) {

const anab::ParticleID &particle_id = *pidPtr;

Updated to the suggested change.

PetrilloAtWork · 2025-10-24T00:53:16Z

sbncode/CAFMaker/FillReco.cxx

+    // Loop over algorithm scores and extract the ones we want.
+    // Get the ndof from any likelihood pid algorithm
+
+    std::vector<anab::sParticleIDAlgScores> AlgScoresVec = particle_id.ParticleIDAlgScores();


Capture it by reference, avoid copies ([CF-111]):

Suggested change

std::vector<anab::sParticleIDAlgScores> AlgScoresVec = particle_id.ParticleIDAlgScores();

std::vector<anab::sParticleIDAlgScores> const& AlgScoresVec = particle_id.ParticleIDAlgScores();

Updated to the suggested change.

PetrilloAtWork · 2025-10-24T00:54:58Z

sbncode/CAFMaker/FillReco.cxx

+    for (size_t i_algscore=0; i_algscore<AlgScoresVec.size(); i_algscore++){
+      anab::sParticleIDAlgScores AlgScore = AlgScoresVec.at(i_algscore);


Avoid copying the objects, and also compact the notation:

Suggested change

for (size_t i_algscore=0; i_algscore<AlgScoresVec.size(); i_algscore++){

anab::sParticleIDAlgScores AlgScore = AlgScoresVec.at(i_algscore);

for (anab::sParticleIDAlgScores const& AlgScore: AlgScoresVec){

Updated to the suggested change.

PetrilloAtWork · 2025-10-24T01:18:23Z

sbncode/CAFMaker/FillReco.cxx

+        if (TMath::Abs(AlgScore.fAssumedPdg) == 13) { // lambda_mu
+          srlikepid.lambda_muon = AlgScore.fValue;
+          srlikepid.pid_ndof = AlgScore.fNdf;
+        }
+        else if (TMath::Abs(AlgScore.fAssumedPdg) == 211) { // lambda_pi
+          srlikepid.lambda_pion = AlgScore.fValue;
+          srlikepid.pid_ndof = AlgScore.fNdf;
+        }
+        else if (TMath::Abs(AlgScore.fAssumedPdg) == 2212) { // lambda_pr
+          srlikepid.lambda_proton = AlgScore.fValue;
+          srlikepid.pid_ndof = AlgScore.fNdf;
+        }


Since the cases are known integral numbers, it's more efficient to use switch:

Suggested change

if (TMath::Abs(AlgScore.fAssumedPdg) == 13) { // lambda_mu

srlikepid.lambda_muon = AlgScore.fValue;

srlikepid.pid_ndof = AlgScore.fNdf;

}

else if (TMath::Abs(AlgScore.fAssumedPdg) == 211) { // lambda_pi

srlikepid.lambda_pion = AlgScore.fValue;

srlikepid.pid_ndof = AlgScore.fNdf;

}

else if (TMath::Abs(AlgScore.fAssumedPdg) == 2212) { // lambda_pr

srlikepid.lambda_proton = AlgScore.fValue;

srlikepid.pid_ndof = AlgScore.fNdf;

}

switch (std::abs(AlgScore.fAssumedPdg)) {

case 13: // lambda_mu

srlikepid.lambda_muon = AlgScore.fValue;

srlikepid.pid_ndof = AlgScore.fNdf;

break;

case 211: // lambda_pi

srlikepid.lambda_pion = AlgScore.fValue;

srlikepid.pid_ndof = AlgScore.fNdf;

break;

case 2212: // lambda_pr

srlikepid.lambda_proton = AlgScore.fValue;

srlikepid.pid_ndof = AlgScore.fNdf;

break;

}

Updated to the suggested change.

sungbinoh · 2025-10-28T15:26:21Z

Hi @PetrilloAtWork , thanks a lot for your review!
I have updated codes following the comments.

For default values for the SRTrkLikelihoodPID, adding srlikepid.setDefault(); in FillReco.cxx.

sungbinoh added 3 commits October 20, 2025 09:54

adding TrackLikePidLabel in CAFMakerParams.h

9bea391

updating FillReco for likelihood pid

2af2c08

update CAFMaker_module.cc for likelihood pid

3eeef15

sungbinoh requested a review from henrylay97 October 20, 2025 16:54

sungbinoh self-assigned this Oct 20, 2025

sungbinoh requested a review from PetrilloAtWork October 20, 2025 16:54

sungbinoh added the enhancement New feature or request label Oct 20, 2025

sungbinoh mentioned this pull request Oct 20, 2025

adding TrackLikePidLabel: to cafmakerjob fcl files SBNSoftware/sbndcode#853

Open

7 tasks

henrylay97 approved these changes Oct 21, 2025

View reviewed changes

sungbinoh added 3 commits October 21, 2025 09:50

likepid default values to -5.

2af891e

like pid lambda default value to -99999.

2651da1

updating SRTrkLikePID to SRTrkLikelihoodPID

ff96233

sungbinoh mentioned this pull request Oct 21, 2025

Adding SRTrkLikelihoodPID class into the StandardRecord SBNSoftware/sbnanaobj#168

Open

henrylay97 reviewed Oct 23, 2025

View reviewed changes

removing defaulting part for likelihood pid

264bd4f

henrylay97 approved these changes Oct 23, 2025

View reviewed changes

sbncode/CAFMaker/CAFMaker_module.cc Show resolved Hide resolved

PetrilloAtWork requested changes Oct 24, 2025

View reviewed changes

Following Gianluca's comments

4c47688

adding setDefault for likelihood pid

ad25a04

	void FillTrackLikePID(const std::vector<art::Ptr<anab::ParticleID>> particleIDs,
	void FillTrackLikePID(const std::vector<art::Ptr<anab::ParticleID>>& particleIDs,

		for (unsigned i = 0; i < particleIDs.size(); i++) {
		const anab::ParticleID &particle_id = *particleIDs[i];

	std::vector<anab::sParticleIDAlgScores> AlgScoresVec = particle_id.ParticleIDAlgScores();
	std::vector<anab::sParticleIDAlgScores> const& AlgScoresVec = particle_id.ParticleIDAlgScores();

		for (size_t i_algscore=0; i_algscore<AlgScoresVec.size(); i_algscore++){
		anab::sParticleIDAlgScores AlgScore = AlgScoresVec.at(i_algscore);

	for (size_t i_algscore=0; i_algscore<AlgScoresVec.size(); i_algscore++){
	anab::sParticleIDAlgScores AlgScore = AlgScoresVec.at(i_algscore);
	for (anab::sParticleIDAlgScores const& AlgScore: AlgScoresVec){

Feature/sungbino likepid into cafmaker #593

Are you sure you want to change the base?

Feature/sungbino likepid into cafmaker #593

Uh oh!

Conversation

sungbinoh commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

henrylay97 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henrylay97 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henrylay97 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PetrilloAtWork left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sungbinoh commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sungbinoh commented Oct 20, 2025 •

edited

Loading

sungbinoh commented Oct 28, 2025 •

edited

Loading