Skip to content

Conversation

@linyan-w
Copy link
Contributor

@linyan-w linyan-w commented Oct 8, 2025

Description

For enhanced samples (nue, NCpi0, etc), a way to identify them in standard stream CAFs are necessary to scale & merge the enhanced samples. In principal all the info is there in the EventRecord in CAF files. This PR adds more variables to flat CAFs for easier check.

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@linyan-w linyan-w requested review from kjplows and lynnt20 October 8, 2025 18:28
@linyan-w linyan-w self-assigned this Oct 8, 2025
@linyan-w linyan-w added the enhancement New feature or request label Oct 8, 2025
@linyan-w linyan-w moved this to Waiting on Reviewer in SBND 2025 Fall Production - Validation Oct 8, 2025
@linyan-w linyan-w moved this from Waiting on Reviewer to Reviewer Approved in SBND 2025 Fall Production - Validation Oct 8, 2025
@linyan-w linyan-w changed the title Add IsCC to flat GENIE tree Add interaction info to flat GENIE tree Oct 9, 2025
@kjplows
Copy link
Contributor

kjplows commented Oct 16, 2025

Hi @PetrilloAtWork , just a ping to check if these additions to the flat GENIE tree in the flat CAFs look good to you?
(these map directly to the ScatteringType and InteractionType GENIE uses, the documentation @linyan-w added points to that). Thanks!

@kjplows
Copy link
Contributor

kjplows commented Oct 16, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_10_03

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes suggested.
Nothing critical, feel free to push back if you don't agree.
(but please do fix the alignment)

linyan-w and others added 2 commits October 22, 2025 17:12
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
@linyan-w
Copy link
Contributor Author

Some changes suggested. Nothing critical, feel free to push back if you don't agree. (but please do fix the alignment)

Thanks for the suggestions! All sound great and adopted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Partially reviewed
Status: Reviewer Approved

Development

Successfully merging this pull request may close these issues.

5 participants