- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33
Add interaction info to flat GENIE tree #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| Hi @PetrilloAtWork , just a ping to check if these additions to the flat GENIE tree in the flat CAFs look good to you? | 
| trigger build LArSoft/lar*@LARSOFT_SUITE_v10_10_03 | 
| ✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard | 
| ✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard | 
| ❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard | 
| ❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard | 
| 🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard | 
| ❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes suggested.
Nothing critical, feel free to push back if you don't agree.
(but please do fix the alignment)
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>
| 
 Thanks for the suggestions! All sound great and adopted. | 
Description
For enhanced samples (nue, NCpi0, etc), a way to identify them in standard stream CAFs are necessary to scale & merge the enhanced samples. In principal all the info is there in the EventRecord in CAF files. This PR adds more variables to flat CAFs for easier check.