Copy cafe to build directory so we don't have to run mrbslp#110
Copy cafe to build directory so we don't have to run mrbslp#110jedori0228 wants to merge 2 commits intodevelopfrom
Conversation
… to run cafe script
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
There was a problem hiding this comment.
The PR clarifies well the need for the first change, but I miss the explanation for the second one.
| } | ||
| else{ | ||
| gROOT->Macro("${MRB_BUILDDIR}/sbnana/bin/rootlogon.C"); | ||
| gROOT->Macro("${SBNANA_DIR}/sbnana/CAFAna/rootlogon.C"); |
There was a problem hiding this comment.
This new version appears to mirror the setup strategy in cafe script.
Nevertheless I do not understand the motivation of this change. Can you explain?
There was a problem hiding this comment.
Without this PR, users ran mrbslp before they run cafe. ${SBNANA_FQ_DIR} is only set after mrbslp, and for this case it looks for "${SBNANA_FQ_DIR}/bin/rootlogon.C" which exists. This PR helps user to run cafe without running mrbslp, and there we have empty ${SBNANA_FQ_DIR}. I then found we don't have "${MRB_BUILDDIR}/sbnana/bin/rootlogon.C", but it exists under "${SBNANA_DIR}/sbnana/CAFAna/rootlogon.C"
There was a problem hiding this comment.
While checking more on this, it looks like just using tagged sbnana with setup sbnana v09_75_03 -qe20:prof does not suffer from this issue, where most of the users (I guess) check out the product and use local products
There was a problem hiding this comment.
If you setup sbnana (either explicitly or indirectly with mrbslp), SBNANA_FQ_DIR is set so this part of the code would be skipped. That could explain your last statement.
|
@jedori0228 @PetrilloAtWork What's the status of this PR? I'm preparing a release and would like to include all open PRs that can be pushed. let me know! |
|
is this PR still needed? @jedori0228 ? |
|
It is not necessary, but at leaset helping me a lot.. I don't have to keep doing |
|
@jedori0228, have you considered using |
|
I am not sure which is the better solution, actually. |
|
@jedori0228 , just checking in - have you had time to check Gianluca's suggestions here? Thanks |
4 participants
cafescript is not seen from thebuilddirectory, but only copied tolocalProductsduring theinstallstep.mrbsetenvappends thebuilddirectory to${PATH}, so users have to runmrbslpto uselocalProductsinstead. (and then had to runmrbsetenvto compile the code, and thenmrbslpto runcafe...)This fix copies the script to
builddirectory and then copies it again tolocalProductsduringinstall, so can runcafewithout runningmrbslp.