Skip to content

First week testing @enric101 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
enric11 wants to merge 2 commits into from
Closed

First week testing @enric101 #9

enric11 wants to merge 2 commits into from

Conversation

@enric11
Copy link

@enric11 enric11 commented Jun 9, 2022

An exciting challenge! Thanks a lot!

@enric11 enric11 requested a review from nicoschoenteich as a code owner June 9, 2022 21:51
@nicoschoenteich
Copy link
Contributor

nicoschoenteich commented Jun 10, 2022 •
edited
Loading

Hi @enric11 !
Thanks a lot for your PR. Looks like the GitHub action is failing because it cannot install all the dependencies due to unsynchronized package.json and package-lock.json. Can you maybe try and push your code again without the package-lock.json file? Your app looks fine so the tests should pass then.
BR, Nico

nicoschoenteich
nicoschoenteich requested changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@nicoschoenteich nicoschoenteich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment in the thread

@enric11 enric11 closed this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoschoenteich nicoschoenteich nicoschoenteich requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enric11 @nicoschoenteich