Skip to content

Conversation

@whydrae
Copy link

@whydrae whydrae commented Jun 11, 2022

Please, see my tests pass for week 1.

@whydrae whydrae requested a review from nicoschoenteich as a code owner June 11, 2022 13:46
@cla-assistant
Copy link

cla-assistant bot commented Jun 11, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ whydrae
✅ nicogeburek
❌ i303610


i303610 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nicoschoenteich
Copy link
Contributor

Hi @whydrae, thanks for taking part in the challenge!
We had some issues with the starter project and its GitHub action, which we fixed. But your app looks fine, so I would still consider it a successful entry for the first week. Fetching the upstream should update this PR and make the action succeed. You can do that now or wait until Wednesday, when we will add a new test to the project.

@nicoschoenteich
Copy link
Contributor

Hi @whydrae, we finally got it 😉

@whydrae
Copy link
Author

whydrae commented Jun 14, 2022

Hi @whydrae, we finally got it 😉

Hi Nico! Indeed, thank you!

@whydrae whydrae closed this Jun 14, 2022
@nicoschoenteich
Copy link
Contributor

Let's keep the PR open and green, as a sign that it is a successful challenge entry ✅

@whydrae
Copy link
Author

whydrae commented Jun 15, 2022

@nicogeburek, sorry, I think I broke my repository. I'll create a new merge request with changes for both weeks :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants