week1 #15
Closed
week1 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nicoschoenteich
requested changes
Jun 11, 2022
Contributor
nicoschoenteich
left a comment
nicoschoenteich
left a comment
There was a problem hiding this comment.
Hi @marcellourbani, thanks a lot for your submission! We had some issues with the package-lock.json. Can delete your package-lock.json? This should make the test also pass here in the GitHub action. Thanks!
Author
|
Ok, done |
Author
|
redone with trivial changes and worked |
Contributor
|
Hi @marcellourbani, writing you here to let you know that your other pull request was successfully deleted. GitHub support was fast 👍🏻 |
Author
|
Oh thanks!
Had that stuff in .gitignore but probably messed up some merge .
Afraid deleting keys will be most of my day :(
…On Tue, Jun 14, 2022 at 9:44 AM Nico Geburek ***@***.***> wrote:
Hi @marcellourbani <https://github.com/marcellourbani>, writing you here
to let you know that your other pull request was successfully deleted.
GitHub support was fast 👍🏻
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASW6HKUMMR6IV2SYYNMA7DVPBA6XANCNFSM5YPVXB3A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.