Merged
Conversation
|
|
Contributor
|
rebase on main? |
beckermarc
force-pushed
the
review-feedback
branch
from
8281877 to
b843f29
Compare
beckermarc
reviewed
Dec 19, 2024
| * Hierarchically organized Code List for Genres | ||
| */ | ||
| entity Genres { | ||
| entity Genres : sap.common.CodeList { |
Contributor
There was a problem hiding this comment.
@OlenaTi @etimr: What harm did the value help make, that's implicitly included in CodeList? If it did any harm I think the better approach would be to remove the annotation on GenreHierarchy by annotating it with @cds.odata.valuelist: false
Contributor
There was a problem hiding this comment.
@beckermarc you are right, it also works without @cds.odata.valuelist: false now: #420
beckermarc
approved these changes
Dec 19, 2024
Contributor
Author
|
Before the merge I need to check if the value-help is still working ... |
Contributor
Author
is working for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.