Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

[NoRef-0] allow special characters for cf user password #487

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

biehlera
Copy link

Purpose

If you have a special character in the password for the cloud foundry login you get an error message because the password is not properly escaped.

Does the PR solve an issue

[ ] Yes - Please add issue number
[X] No

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

manual testing with special characters e.g. $ &

@cla-assistant
Copy link

cla-assistant bot commented Apr 17, 2023

CLA assistant check
All committers have signed the CLA.

@lechnerc77 lechnerc77 changed the base branch from main to dev April 18, 2023 06:09
@lechnerc77 lechnerc77 added the bug Something isn't working label Apr 18, 2023
@lechnerc77 lechnerc77 added this to the to be planned milestone Apr 18, 2023
@SAP-samples SAP-samples deleted a comment from cla-assistant bot Apr 18, 2023
@lechnerc77 lechnerc77 merged commit 135119e into SAP-samples:dev Apr 18, 2023
@lechnerc77
Copy link
Member

@biehlera Thanks for your contribution. It is merged into the dev branch and will be available in main with the next release (date t.b.d.).

@lechnerc77
Copy link
Member

Pre-build Docker image for dev branch is available:

https://github.com/SAP-samples/btp-setup-automator/pkgs/container/btp-setup-automator-dev

@lechnerc77 lechnerc77 added the available in dev fix/enhancement is available in dev label Apr 18, 2023
@lechnerc77 lechnerc77 modified the milestones: to be planned, btpsa-v1.8.0 Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
available in dev fix/enhancement is available in dev bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants