Skip to content

feat(shared-filesystem-storage): migrate ShareNetworkList to functional TypeScript (#2033)#2044

Open
hodanoori wants to merge 1 commit into
masterfrom
hoda-react19-share-networks-list
Open

feat(shared-filesystem-storage): migrate ShareNetworkList to functional TypeScript (#2033)#2044
hodanoori wants to merge 1 commit into
masterfrom
hoda-react19-share-networks-list

Conversation

@hodanoori
Copy link
Copy Markdown
Contributor

@hodanoori hodanoori commented May 12, 2026

Summary

Migrates ShareNetworkList in the shared filesystem storage plugin from a class component to a functional TypeScript component as part of the React 19 migration epic (#1774).

Changes Made

  • Replace class component ShareNetworkList with a functional TypeScript component in list.tsx
  • Replace componentDidMount and UNSAFE_componentWillReceiveProps with a single useEffect reacting to active and shareNetworks
  • Convert loadDependencies, network, and subnet class methods to plain functions
  • Add TypeScript interfaces for ShareNetwork, NetworksState, SubnetsForNetwork, and ShareNetworkListProps
  • Delete list.jsx
  • Add list.test.tsx with 14 unit tests covering dependency loading, loading state, table rendering, network/subnet resolution, and permission-gated Create New button

Related Issues

Screenshots (if applicable)

4818AFE4-1C5F-431B-9093-9EE49CA1EE77

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@hodanoori hodanoori self-assigned this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task](share_networks): Migrate share_networks/list.jsx to React 19

1 participant