Skip to content

feat(shared-filesystem-storage): migrate EditShareNetworkForm to functional TypeScript (#2032)#2043

Open
hodanoori wants to merge 1 commit into
masterfrom
hoda-react19-share-networks-edit
Open

feat(shared-filesystem-storage): migrate EditShareNetworkForm to functional TypeScript (#2032)#2043
hodanoori wants to merge 1 commit into
masterfrom
hoda-react19-share-networks-edit

Conversation

@hodanoori
Copy link
Copy Markdown
Contributor

@hodanoori hodanoori commented May 12, 2026

Summary

Migrates EditShareNetworkForm in the shared filesystem storage plugin from a class component to a functional TypeScript component as part of the React 19 migration epic (#1774).

Changes Made

  • Replace class component EditShareNetworkForm with a functional TypeScript component in edit.tsx
  • Replace UNSAFE_componentWillReceiveProps with useEffect reacting to the shareNetwork prop
  • Convert show state to useState, close and onSubmit to useCallback
  • Add TypeScript interfaces for ShareNetwork, History, and EditShareNetworkFormProps
  • Delete edit.jsx
  • Add edit.test.tsx with 9 unit tests covering modal visibility, form fields, cancel behaviour, and form submission

Related Issues

Screenshots (if applicable)

33C7B144-B961-4E47-9E34-973D8428D257

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@hodanoori hodanoori self-assigned this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task](shared_networks): Migrate share_networks/edit.jsx to React 19

1 participant