v2.x - Nokogiri Refactor Part 5: Extract out RubySaml::XML::Decryptor + Decoder #758
+1,624
−1,417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes from #745, please merge that one first.
This does the following changes:
RubySaml::XML::DecoderRubySaml::XML::DecryptorRubySaml::XMLmoduleBase64.strict_encode64everywhere. The only difference betweenBase64.strict_encode64andBase64.encode64is that the latter doesn't insert newline chars, while the former does. By usingstrict_encode64we can remove a lot of.gsub("\n", "")calls.