Allow use of TLS without custom/self-signed certificate chain #349
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bj00rn
force-pushed
the
chore/allow-tls-without-custom-ca
branch
from
75b7d87 to
2b0ec29
Compare
bj00rn
force-pushed
the
chore/allow-tls-without-custom-ca
branch
from
2b0ec29 to
d8c8931
Compare
nanomad
previously approved these changes
Jun 17, 2025
| ssl_context.check_hostname = False | ||
| if cert_uri: | ||
| ssl_context.load_verify_locations(cafile=cert_uri) | ||
| ssl_context.check_hostname = False |
There was a problem hiding this comment.
I wonder if this is a good idea. I'd rather see a new settings to override it. @bj00rn I'll merge as is but I'd like a new PR where we can configure this flag, defaulting it to True
We'll update the changelog accordingly noting the breaking change
|
@bj00rn Please solve the merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow secure connections over TLS without providing self signed certificate chain.
fixes #347