Skip to content

Use ISO/UTC timestamps in the Waveform CSV and parquet files - #109

Merged
jeremyestein merged 4 commits into
devfrom
jeremy/timestamps
Oct 2, 2026
Merged

jeremyestein merged 4 commits into
devfrom
jeremy/timestamps

Conversation

@jeremyestein

Copy link
Copy Markdown
Collaborator

To match the timestamps we're using in the EHR parquets.

the timestamps we're using in the EHR parquets.
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.68%. Comparing base (42ced62) to head (25be712).
⚠️ Report is 2 commits behind head on ehr_queries_clean.

Files with missing lines Patch % Lines
src/exporter/daily_summary.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           ehr_queries_clean     #109      +/-   ##
=====================================================
+ Coverage              74.47%   74.68%   +0.20%     
=====================================================
  Files                     18       18              
  Lines                    862      881      +19     
  Branches                  73       74       +1     
=====================================================
+ Hits                     642      658      +16     
- Misses                   194      196       +2     
- Partials                  26       27       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thompson318 thompson318 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question in controller.py

Comment thread src/controller.py Outdated
Comment thread src/csv_writer.py Outdated
Co-authored-by: Stephen Thompson <s.thompson@ucl.ac.uk>

@thompson318 thompson318 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@skeating skeating left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

Base automatically changed from ehr_queries_clean to dev October 2, 2026 15:21
@jeremyestein
jeremyestein merged commit 5178d8d into dev Oct 2, 2026
4 checks passed
@jeremyestein
jeremyestein deleted the jeremy/timestamps branch October 2, 2026 15:27

This branch was successfully deployed

1 active deployment
hasher — 25be712b Deployed Oct 1, 2026 by jeremyestein via Run pytest #220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants