Skip to content

Conversation

@aplikethewatch
Copy link
Contributor

No description provided.

@jwthomson
Copy link
Contributor

In the Github preview the numbering keeps restarting, I think because the indentation is not quite right. Have you / could you please check to see if this is happening in your local docs instance?

image

@aplikethewatch
Copy link
Contributor Author

ah bugger. will have a look, cheers.

@jwthomson
Copy link
Contributor

jwthomson commented May 9, 2025

I ran through the process from start to end and it nearly worked 😉

Missing steps:

  1. Fix the npm ci command as per your PR: move package.json and package-lock.json to /src/Client SAFE-template#658
  2. Set up for a resolve config in the vite config, which when missing, gives package resolution errors.

But other than those, and the comments I left (which are minor), I think the instructions are solid and easy to follow - and of course they work! Thanks Amir 😄

@aplikethewatch
Copy link
Contributor Author

aplikethewatch commented May 12, 2025

once SAFE-Stack/SAFE-template#658 has been approved:

  • remove #### 2. Move package.json & package-lock.json to /src/Client

new changes to safe template has moved package.json to the src/Client directory
@aplikethewatch aplikethewatch requested a review from jwthomson May 16, 2025 11:09
Copy link
Contributor

@jwthomson jwthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good - maybe the only thing I might add is a note to let people know that if they have old version of the template then they will need to move the package.json file into client, maybe link to the PR with the change so they can see what is required for themselves?

@aplikethewatch aplikethewatch merged commit 6b1abf3 into master May 16, 2025
@aplikethewatch aplikethewatch deleted the shadcn-recipe branch May 16, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants