Skip to content

Conversation

@nick-kramer117
Copy link

No description provided.

@timverwaal
Copy link
Contributor

I submitted a very similar PR #246. Thus, #277, #278 and #246 can be pulled as one item I think. Hopefully it will be part of a next release.

@timverwaal timverwaal mentioned this pull request Aug 5, 2020
@mycroes
Copy link
Member

mycroes commented Aug 5, 2020

Sorry for the massive delay in response and releases. I hope to catch up on all these very soon (this week or next week). For now, thanks for the effort.

@nick-kramer117
Copy link
Author

nick-kramer117 commented Aug 5, 2020 via email

@mycroes
Copy link
Member

mycroes commented Aug 13, 2020

Hi @nick-kramer117 ,

Sorry for my late reply. I will happily accept PR's and I will try to merge them quicker (and do releases when changes get merged). I wouldn't mind adding more developers either, but I would mind if the code would get even messier than it already is. This honestly isn't my library either, I only made some minor contributions while most of the work has been done by others way before I ever got involved. Unfortunately the previous developers and maintainers lost their need and/or interest and as such development has slowed down.

There's actually a few things that I intend to do with S7NetPlus (short term, as far as that'll work):

  • Improve connect exception details, because it's the major reason for bugs
  • Add a sample project
  • Provide a synchronized implementation

I'd love someone else to contribute to this though, that'll also motivate me more to spend time on S7NetPlus. Last but not least, I'm not maintaining any other projects where people other than me contribute, so maybe I can add you as contributor with limited permissions (at first), but I'd actually have to look into what is feasible in that sense.

Let me know what you think about all this, I especially don't want to scare you off, the project can use contributors.

mycroes added a commit to mycroes/s7netplus that referenced this pull request Aug 13, 2020
PR S7NetPlus#246 included most types also included in S7NetPlus#277, this adds OB, OW and
OD that were only in S7NetPlus#277.

Close S7NetPlus#277.
@mycroes mycroes closed this in #281 Aug 13, 2020
mycroes added a commit that referenced this pull request Aug 13, 2020
PLCAddress: Add OB, OW, OD types from PR #277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants