Fixed received data size checking to avoid IndexOutOfRange exception #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the method ReadBytesWithSingleRequestAsync in the file PlcAsynchronous.cs is the exact same check without your extension. It would be nice to have both cases fixed with the same PR. |
mycroes
added a commit
to mycroes/s7netplus
that referenced
this pull request
Aug 13, 2020
Member
|
@zoltraks Thanks for your contribution. I took note of @jakob-ledermann 's comment and addressed this issue in #282. Unfortunately this won't 'fix' the problem (that when PUT/GET is blocked you get an exception), but at least it will provide better error messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem when trying to read DB from a PLC which has "Permit access with PUT/GET communication from remote partner" option in "Protection & Security" unchecked.