Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap Toggle & Start buttons #143

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Swap Toggle & Start buttons #143

merged 4 commits into from
Jan 6, 2022

Conversation

shirleydekoster
Copy link
Collaborator

No description provided.

@S010MON
Copy link
Owner

S010MON commented Jan 3, 2022

This is currently failing to compile, please address the compilation issues indicated in the tests and try pushing again.

Also, can you please rename the PR to something more accurate like "Swap_toggle/start_button"

@AlexHartmann00 AlexHartmann00 changed the title Try swap button Swap Toggle & Start buttons Jan 4, 2022
AlexHartmann00
AlexHartmann00 reviewed Jan 4, 2022
View reviewed changes
Copy link
Collaborator

@AlexHartmann00 AlexHartmann00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, I was thinking about changing the label of the Toggle button? I dont think its very intuitive

S010MON
S010MON requested changes Jan 4, 2022
View reviewed changes
Copy link
Owner

@S010MON S010MON left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the image to a picture of the colours being swapped and this will be approved

@shirleydekoster shirleydekoster merged commit c3f5c55 into main Jan 6, 2022
@AlexHartmann00 AlexHartmann00 deleted the swap_button branch January 7, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexHartmann00 AlexHartmann00 AlexHartmann00 left review comments

@S010MON S010MON S010MON approved these changes

Assignees

@shirleydekoster shirleydekoster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shirleydekoster @S010MON @AlexHartmann00