Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration/gatsby#2 #6

Merged
merged 12 commits into from
Oct 28, 2018
Merged

Migration/gatsby#2 #6

merged 12 commits into from
Oct 28, 2018

Conversation

ttristan
Copy link
Contributor

@ttristan ttristan commented Aug 5, 2018

  • Performance 85 -> 91
  • PWA 73 -> 100
  • Accessibility 55 -> 100
  • Best Practices 81 -> 100
  • SEO 85 -> 100

fixes #3

@virtualandy
Copy link

Anything we can help test or try to get this merged? I realize Gatsby V2 is still unofficial, heh.
Want to start using this template (and am happy to use @ttristan's fork - thanks @ttristan ) so just curious on status. Thanks for putting it together in the first place!

@RyanFitzgerald
Copy link
Owner

Thanks for your interest in it! This was put on hold temporarily waiting on an official release of V2 which should be coming soon. Most of the testing is done and all the work @ttristan put in looks great. If you're using the fork and notice anything, definitely feel free to open an issue or let us know. In the mean time, I may merge it into a separate branch and then merge that into the main branch once it's officially released. Hope that helps.

@virtualandy
Copy link

Makes sense and no worries. Will keep my eye on the fork to see if anything is amiss. So far so good...

@RyanFitzgerald
Copy link
Owner

Revisiting this now that V2 is officially released.

@RyanFitzgerald
Copy link
Owner

Sorry for the delay on this, all the changes look good and work with the upgrade. There are a couple issues I'll address since a couple things have changed since this PR, but that's on me. Thanks again for the work yo u put into this.

@RyanFitzgerald RyanFitzgerald merged commit 1aa5b7f into RyanFitzgerald:master Oct 28, 2018
@ttristan
Copy link
Contributor Author

Good stuff, nice to see it finally merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighthouse audit reports issues
3 participants